DMS rounding errors, display truncation; expand DMS syntax

[skylerbunny]

Much to my (pleasant) surprise, I discovered that it is in fact possible to paste a DMS lat/lon into the iD search box, because I dug deep enough to find this change, 702e3d2 .

The trouble is as it is now, it seems to accept exactly one (undocumemted) format for such a cut/paste. It is:

[D]DD°MM'SS.[S]"[NS],[D]DD°MM'SS.[S]"[EW]

There are a few issues I've identified:

1. If you enter a location with a negative rather than NSEW, it is actually converted and centered incorrectly:

45°,-90°0'0.5" (to be 45,89°59'59.? W, so it's subtracting wrong somewhere)

2. Location display rounding is performed around certain cases that shouldn't be, as implied by the above:
   45°,90°0'0.9" shows as 45°N,90° (seems that < 1 second is just dropped from the display)
   45°,90°0'1" shows as 45°N,90°0'1" (that's actually correct!)
   45°,90°0'1.1" still autocompletes as 45°,90°0'1" (display not correct because decimals are dropped, but I think the centering is right)

(1) and (2) make it difficult to assume that the entry of a dms style coordinate pair 'works' correctly, either because it's displayed with bad rounding, or it actually centers on the wrong place.

3. I guess this is technically an RFE, but I'll toss it in if people are working on the above as defects anyway:
   It would be really awesome if one could paste a dms that looks like this, because it's really common to see done like this:
   45 0 18.229944, -90 19 0.4445 (or) 45 0 18.229944 N, 90 19 0.4445 W

[skylerbunny]

I mentioned (3) above because otherwise, the only viable way of putting in a DMS location into the search box is by using the extended character '°', which might not be easily guessed. If a pair of decimals can be discerned by the engine to be a decimal coordinate pair, I'm assuming 'three whitespace separated numbers within the constrants of -90/90, 0-60, 0.60,-180/180, 0-60, 0.60 might also be without too much trouble.

[bhousel]

Good suggestions, this relates to #5214

[1ec5]

In #4672 I was only trying to use DMS format for display, but it’s a happy coincidence that it works at all as input, hence the requirement to use proper typographic characters ° ′ ″ rather than o ' ".

[skylerbunny]

Oh, no worries, I'm absolutely with you on that statement, and you have nothing to defend! The reason I opened this is, "because it IS possible to use DMS as an input to the search box", I've identified bugs with doing so translating between the input and what the system browses to as the actual point.

It's kind of an accidental feature, but knowing this, it's a good idea to either fix bugs relating to using it, or disable it in the search to avoid that, IMO.

Generalizing the input allowed for a valid DMS search would be nice as well, of course. But I had no expectation that it should or does "just work that way" on day one or anything.