NSI validator suggests replacing Greyhound and GoBus with BoltBus

[1ec5]

This route relation belongs to GoBus, a brand owned by Barons Bus Lines as part of the Greyhound network. For some reason, the name-suggestion-index validator wants to replace the tags with those of BoltBus, which was operated by Greyhound but just went out of business.

Even a normal Greyhound line can trigger a warning about BoltBus:

[1ec5]

It probably would be reasonable to add an NSI entry for GoBus. Also, not:operator:wikidata should suppress the validator warning along the lines of #6577. But the apparent mismatch in the network matching code seems more concerning.

[mbrzakovic]

this PR was a great upgrade, however it is possible that it introduced the behavior you described.
@bhousel can you please take a look at this?

[bhousel]

It probably would be reasonable to add an NSI entry for GoBus. Also, not:operator:wikidata should suppress the validator warning along the lines of #6577. But the apparent mismatch in the network matching code seems more concerning.

I looked into this today - It's because NSI has Greyhound as network=Greyhound Lines not network=Greyhound.

These are the tags on the route:

The validator tries matching this route against 4 k/v/n tuples in this order:

It doesn't match the primary "Greyhound" so starts falling back to other alternate values.

Q755309 matches both Bolt Bus and Greyhound Lines as an alternate match, and it took the Bolt Bus one.

To fix this right now, I can:

• Add a matchName "Greyhound" to NSI item for "Greyhound Lines".
• Or - rename the item to "Greyhound" and add a matchName for "Greyhound Lines" if that's really how people tag? I'll check overpass and see.

[bhousel]

To fix this right now, I can:

• Add a matchName "Greyhound" to NSI item for "Greyhound Lines".
• Or - rename the item to "Greyhound" and add a matchName for "Greyhound Lines" if that's really how people tag? I'll check overpass and see.

Just following up - it's overwhelmingly mapped with network=Greyhound so we'll keep it that way for now in NSI.

[bhousel]

Published v6.0.20210730 and I'm getting much more reasonable tag suggestion now:
(older version may be served from the CDN to some users for a few hours more).