Skip to content

show empty tag values in multi-selections#10002

Merged
tyrasd merged 4 commits intoopenstreetmap:developfrom
k-yle:9876-multiple-values-empty
Dec 6, 2023
Merged

show empty tag values in multi-selections#10002
tyrasd merged 4 commits intoopenstreetmap:developfrom
k-yle:9876-multiple-values-empty

Conversation

@k-yle
Copy link
Copy Markdown
Collaborator

@k-yle k-yle commented Nov 25, 2023

Closes #9876

If you select a node with natural=* and another node with no natural tag, the multiselect dropdown now includes (empty) as an option, to avoid confusion.

@tyrasd tyrasd added the enhancement An enhancement to make an existing feature even better label Dec 6, 2023
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've made a few minor tweaks:

  • use italic font style to make option visibly different from regular tag values
  • switch back to use the raw tag value as the displayed option label in the combobox dropdown: using d.title was confusing for tags where taginfo returns rather long descriptions (these are still displayed as the respective option's hover text, btw)

@tyrasd tyrasd merged commit bb17d5c into openstreetmap:develop Dec 6, 2023
@tyrasd tyrasd added the usability An issue with ease-of-use or design label Dec 6, 2023
@k-yle k-yle deleted the 9876-multiple-values-empty branch December 8, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement to make an existing feature even better usability An issue with ease-of-use or design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null hiding among "multiple values"

2 participants