show empty tag values in multi-selections#10002
Merged
tyrasd merged 4 commits intoopenstreetmap:developfrom Dec 6, 2023
Merged
show empty tag values in multi-selections#10002tyrasd merged 4 commits intoopenstreetmap:developfrom
tyrasd merged 4 commits intoopenstreetmap:developfrom
Conversation
tyrasd
approved these changes
Dec 6, 2023
Member
tyrasd
left a comment
There was a problem hiding this comment.
Thanks. I've made a few minor tweaks:
- use italic font style to make option visibly different from regular tag values
- switch back to use the raw tag value as the displayed option label in the combobox dropdown: using
d.titlewas confusing for tags where taginfo returns rather long descriptions (these are still displayed as the respective option's hover text, btw)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9876
If you select a node with
natural=*and another node with nonaturaltag, the multiselect dropdown now includes(empty)as an option, to avoid confusion.