New validator: mutually exclusive tags#10035
Merged
tyrasd merged 1 commit intoopenstreetmap:developfrom Feb 26, 2024
Merged
Conversation
1ec5
reviewed
Dec 10, 2023
1ec5
reviewed
Dec 10, 2023
Contributor
Author
|
I added dynamic fixes and better titles, thanks @1ec5.
|
Contributor
There are two quotation marks after name in the text, there should only be one. |
Contributor
Author
|
@pnorman Thank you, fixed now. |
1ec5
reviewed
Dec 12, 2023
1ec5
reviewed
Dec 16, 2023
Contributor
Author
|
Updated screenshots
|
mtmail
force-pushed
the
mutually-exclusive-tags-validator
branch
from
be98a11 to
d7d02cb
Compare
mtmail
force-pushed
the
mutually-exclusive-tags-validator
branch
from
d7d02cb to
277b5d4
Compare
Contributor
Author
|
@tyrasd I removed the commented out code, fixed a codespell warning and moved the list of tags to |
tyrasd
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8306, Closes #7589
About 20.000 places currently have
nameandnonameset. https://overpass-turbo.eu/s/1Eyn (map screenshot and discussion at https://community.openstreetmap.org/t/places-with-name-but-also-noname-yes/106858)I chose 'mutually exclusive' but 'incompatible' or 'conflicting' could also work. I'm open to wording suggestions.
Future versions might need to handle values, too. For example
["wheelchair=yes", "ladder=yes"]. Or patterns["noname", "name:*"]In the future I'd like to see the list of pairs maintained by the community in https://github.com/openstreetmap/id-tagging-schema/ like the list of deprecated tags.
Thank you @tyrasd for the iD development workshop at SotM Antwerp.