add crossing:markings tag when connecting crossing#9586
Merged
tyrasd merged 4 commits intoopenstreetmap:developfrom Feb 17, 2025
Merged
add crossing:markings tag when connecting crossing#9586tyrasd merged 4 commits intoopenstreetmap:developfrom
tyrasd merged 4 commits intoopenstreetmap:developfrom
Conversation
Contributor
Author
|
Whoops, I searched but somehow missed #9573. Closing this since that PR was first. |
Collaborator
Contributor
Author
|
Sure, I suppose it's been a while. |
Contributor
Author
|
@tyrasd is there anything I can do to get this reviewed and merged? |
|
Vote to get this merged in |
k-yle
added
bug
k-yle
approved these changes
Jun 1, 2024
Collaborator
k-yle
left a comment
k-yle
left a comment
There was a problem hiding this comment.
I can confirm that this PR works, and I've added some unit tests to be sure
Contributor
Author
|
@tyrasd is this blocked on anything? |
tyrasd
approved these changes
Feb 17, 2025
tyrasd
force-pushed
the
crossing-markings
branch
from
86f0c5a to
fe33bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you press "Connect the features" for, e.g., an unmarked crossing on the crossing highways issue, it applies the crossing type but not
crossing:markings, which immediately results in another issue for incomplete tags. This PR makes it so that the resolution copies that field as well, when it exists.Fixes #9525, Fixes #9922, Fixes openstreetmap/id-tagging-schema#1275