Add rendering for roller_coaster=track and roller_coaster=support#9891
Merged
tyrasd merged 2 commits intoopenstreetmap:developfrom Dec 15, 2023
Merged
Conversation
|
At this point in time both Carto and OsmAnd do render roller coasters, so it would be good to merge this PR. |
tyrasd
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9839 by adding rendering to
roller_coaster=trackandroller_coaster=support.Fits the preset PR and the rendering used in OpenStreetMap Carto.
I am a bit unsure on the rendering of the support beams. Are they being rendered too thick, is the contrast too low?
Before:
After:
