Detached House no longer searchable in feature list

[samscodeco]

Describe the bug
"Detached House" is no longer searchable in the feature list. building=detached shows up as "Freestanding House" (not the correct term in British English).

To Reproduce
Set language to en-GB, create or edit an area, search for "Detached House" in the feature list.

Expected behavior
"Detached House" present in the feature list.

Screenshots

[tordans]

@samscodeco could you check the translations https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#translating to see if maybe the default english was changed (American English) and nothing was added to British English?

[samscodeco]

The translation was changed in Transifex and added to iD in this commit. I've reverted the following incorrect translations by the same user:

Detached House -> Freestanding House
Jetway -> Aerobridge
Barbecue -> Barbeque

[tordans]

@andrewharvey it looks like those changes where from your account? Is there anything left to do here, maybe apply the translations elsewhere.

https://app.transifex.com/openstreetmap/id-editor/translate/#en_GB/$/449668774?q=translation_text%3Adetached

Otherwise it sounds like we can close this. The change will be released with the next update of iD.

[andrewharvey]

Sorry that's my mistake, I meant to edit en_AU but somehow edited en_GB instead. I think what happened is Transifex started defaulting me to en_GB, instead of en_AU.

[tordans]

@tyrasd is there something we can do to speed up the translation update in production? (Still don't quite understand what is pulled automatically where...)

[andrewharvey]

As an aside to this issue, especially when working on en_AU translations I feel it would be easier to manage them directly in GitHub as PRs rather than Transifex. It would give each change a proper review, a space for discussion, voting and to store a record of those discussions for future reference.

[tyrasd]

Managing translations via github would be extremely tedious. 🙈 It's possible to do reviews of translations on transifex. That's something we can enable on a per-language basis.

[tyrasd]

@tyrasd is there something we can do to speed up the translation update in production?

Translations are bundled with each release (npm run translations gets the newest strings, and these are included in the dist folder of the npm package). For small issues like this, it is possible to hand-patch the last tagged release and do a patch-release on npm for that. I've done that now in https://github.com/openstreetmap/id-tagging-schema/releases/tag/v6.9.1