Encourage greater stability for identifiers

[matkoniecz]

Maybe it should be documented somewhere?

See openstreetmap/iD#11527 for problems it can cause (NSI integration in iD becomes confused)

And inducing not needed busywork like this should be avoided.

[bhousel]

NSI does have a check for this, and with the 6.13.1 release of id-tagging-schema, these are the warnings that I see now:

⚠️  Category files without presets at @openstreetmap/id-tagging-schema for their key-value combination:
* no iD source preset found for brands/amenity/college
* no iD source preset found for brands/amenity/driving_school
* no iD source preset found for brands/amenity/food_sharing
* no iD source preset found for brands/amenity/kindergarten
* no iD source preset found for brands/amenity/language_school
* no iD source preset found for brands/amenity/music_school
* no iD source preset found for brands/amenity/prep_school
* no iD source preset found for brands/amenity/school
* no iD source preset found for brands/amenity/training
* no iD source preset found for brands/amenity/university
* no iD source preset found for brands/club/freemasonry
* no iD source preset found for brands/leisure/high_ropes_course
* no iD source preset found for brands/office/insurance_adjuster
* no iD source preset found for brands/office/logistics
* no iD source preset found for brands/office/mortgage
* no iD source preset found for brands/shop/pest_control
* no iD source preset found for brands/shop/plant_hire
* no iD source preset found for brands/shop/power_tools
* no iD source preset found for brands/shop/truck
* no iD source preset found for brands/shop/truck_repair
* no iD source preset found for operators/advertising/screen
* no iD source preset found for operators/amenity/college
* no iD source preset found for operators/amenity/kindergarten
* no iD source preset found for operators/amenity/school
* no iD source preset found for operators/amenity/university
* no iD source preset found for operators/boundary/aboriginal_lands
* no iD source preset found for operators/boundary/national_park
* no iD source preset found for operators/boundary/protected_area
* no iD source preset found for operators/emergency/water_rescue
* no iD source preset found for operators/office/visa
* no iD source preset found for operators/route/tracks

While I don't expect there to be a match for everything, I did expect that this list would be getting smaller over time, not bigger.

I think I can work around the missing amenity/school and similar presets by remapping them in the build to use the new education ones.

[tyrasd]

We should probably stick to a workflow like the following in the future, whenever we want to change the ids/paths of presets that are referenced externally (e.g. by NSI):

1. add placeholder presets under the old presets' id that are

• unsearchable
• reference the strings and fields of the new presets
• have a low matchscore

2. after the id-tagging-schema release that includes the id change: update NSI to use the new ids
3. delete the placeholder presets some time after NSI was updated and released

[bhousel]

You probably don't need to go through all that trouble of creating dummy presets and then removing them later.

NSI already has a list of presetID exceptions and we update it sometimes
(public transport tags was another reason we needed this).

I added the education presets to the list just now:
https://github.com/osmlab/name-suggestion-index/blob/9877ceb8f5aef84b364538352346520c5662e91f/scripts/dist.ts#L181-L196

I'll probably be releasing NSI v7 today - the project was blocked for a few months for other reasons anyway and is overdue for a release.

[tyrasd]

don't need to go through all that trouble

If not, there will always be a (short) period where NSI and the released id-tagging-schema are out of sync. We can minimize it by syncing releases, but browser caches will still add an offset of up to a week where the data sets can be out of sync. Sure, we could argue that this is negligible as it is only a couple of days tops, but I think it's still worth the effort for the few times we shift around preset ids.