Detect missing explicit inheritance where implicit inheritance is blocked

[matkoniecz]

part of #1813 - it would be worth automatically detecting cases where moreFields is missing an explicit inheritance

in general it is typically skipped by mistake, though sometimes may be intentional to skip it

@FloEdelmann - would you be interested in making another magic script detecting such cases?

See say 5555b15 that did it entirely unintentionally and was mostly not noticed

And maybe add also CI checker than on new PRs would detect if moreFields is missing or without explicit inheritance? And if such thing happens post comment asking "are you sure" and explaining situation? (feel free to make one with lorem ipsum, I can try crafting some text for that)

[k-yle]

And maybe add also CI checker than on new PRs would detect if moreFields is missing or without explicit inheritance?

These types of checks which can't be enforced by the JSON schema could instead be added to schema-builder's build script. we already have a few examples of this.

Nowadays you can also write custom linting rules for JSON files very easily, rather than manually writing your own script (which is what NSI has done).

[matkoniecz]

would it also give message at PR time? can it be configured to post comment into PR?

[k-yle]

Yes, but it wouldn't be a PR comment. GitHub would just show a big ❌ next to the commit.

 

If we use a tool like eslint, then there's an additional benefit: you can see the errors next to the corresponding line of code thanks to this github actions feature: