ID wants to add building=parking to an area tagged as building:part=parking

[nyqvist]

In my example I have a building that consists of three parts, all tagged as building:part, the outer area that include all parts is tagged as building=yes. The middle part is tagged as building:part=parking. See the screenshot below:

I think the tag "building" should not be added to an area tagged with "building:part".

[1ec5]

This is essentially due to building=parking being specified in addTags for the Multilevel Parking Garage preset. It would be rather inconvenient to have to add a full set of “* Part” variants for each of the building presets, so maybe a more practical fix would be to special-case *:part in the validation code:

https://github.com/openstreetmap/iD/blob/9bce3b3aac4bf6064be2a189856ad52a9d9f16c4/modules/validations/outdated_tags.js#L52-L64

[bhousel]

Yeah, there are a few things going on here that are not great:

• I don't think people should really be combining building:part with primary tags like amenity, etc.
• building tags should probably not go in addTags. When the parking is mapped as a node, then it automatically gets a building tag, and some people don't like this.

[1ec5]

building tags should probably not go in addTags.

Here’s the code that would be modified to eliminate the warning.