Use embassy=yes instead of embassy=embassy

[overflorian]

Hi,
In iD, I propose to stop suggesting the use of embassy=embassy
An embassy should instead be tagged embassy=yes, as detailled in the documentation.

Current situation

For an embassy the following tags are used:

• office=diplomatic
• diplomatic=embassy
• both values embassy=embassy and embassy=yes are proposed to the user

Proposed evolution

The editor stop to suggest embassy=embassy and only propose the following tags to use, as described in the documentation:

• embassy=yes - an classic embassy with an ambassador
• embassy=high_commission - high commission
• embassy=nunciature - diplomatic mission sent from the Vatican
• embassy=interests_section - a country that represents another sovereign state in a country where it lacks its own diplomatic representation
• embassy=mission - diplomatic mission to or from a multilateral organization such as the United Nations
• embassy=delegation - a delegation is headed by an ambassador
• embassy=branch_embassy - like trade office or cultural centre
• embassy=residence

[tyrasd]

Do I understand you correctly that the issue is that the value embassy is proposed in the "Type" field of the embassy preset? See screenshot below:

[overflorian]

Yes

[matkoniecz]

#341 is related

[overflorian]

Hi, you closed this issue but I still see the "embassy" value in the form. Should I just wait for your implementation to appear?
Thanks.

[tyrasd]

The changes will be published (i.e. made available for the public iD editor) in the next release of this package. I'm still in the process of working through the backlog of the issues of this repository right now, but am planning to publish a release relatively soon (in one or two weeks presumably).

[overflorian]

Thank you very much