how to handle externally hosted ("imageURL") icons

[tyrasd]

we should think about how to handle external images (copy them as part of the build? include them externally and update the privacy statement with an allow list of domains? and so on…).

Originally posted by @tordans in #314 (comment)

[tyrasd]

Currently, these are linked to the privacy setting "Show Third Party Icons" in iD: If enabled, the imageURL icon will be used and if disabled they fall back to the regular icon.

Copying as part of the build could be an option at least for the imageURLs from this repo if we are careful in selecting only icons which are not interfering with our source code license (i.e. no trademarked/proprietary material).

[matkoniecz]

Are we even handling those at all in iD presets? It seems to me that we have literally zero imageURL and therefore it is irrelevant here.

See also ideditor/schema-builder#265

https://github.com/search?q=repo%3Aideditor%2Fschema-builder%20imageURL&type=code is not finding any either

https://github.com/search?q=repo%3Aopenstreetmap%2FiD%20imageURL&type=code seems to do something with it

[tordans]

Yes, we do not have any ATM. I think we should consider removing the option from the schema for one of the next major releases. Maybe a start would be to mark them deprecated in the docs until them.

[matkoniecz]

based on openstreetmap/iD#10254 (review) it seems to be used by NSI

I will close this issue here, note also ideditor/schema-builder#265