Odd behaviour with unspecific crossings

[osmuser63783]

Describe the bug
#837 added tagging of unspecific crossings: highway=crossing without another tag such as crossing=unmarked. I noticed some odd (and maybe unintended?) behaviour.

1. a node that only has highway=crossing doesn't have an icon on the map, so there is no user feedback that it's correctly tagged
2. when you click the yes under raised, the node turns into a feature type "speed table", so the suggested fields for a crossing disappear and those for a speed table show up
3. when you select the crossing type "island", this sets crossing=island and immediately prompts a warning about outdated tags; following the recommendation to "upgrade the tags" unsets crossing=island

Expected behavior

1. Give unspecific crossings an icon
2. Clicking the button to say a crossing is raised shouldn't change the primary feature type and make the other fields (e.g. tactile paving) disappear
3. Selecting an option suggested in the dropdown shouldn't result in tagging that iD considers outdated

Additional context
In case it matters, this was on preview server https://pr-862--ideditor-presets-preview.netlify.app/id/dist/#locale=en

[osmuser63783]

Also, changing the type of a crossing to crossing=no doesn't remove highway=crossing but it probably should.

Sorry if some of the above belong in the repo for iD itself, this isn't clear to me!

[tyrasd]

doesn't have an icon

hm… currently, I had left this one without an icon on purpose, in order to encourage users to select the proper crossing type/subpreset. Also, we don't have a proper icon for a completely unspecific crossing (and we can't use the pedestrian person icon as that one is already used for the Unmarked Crossing preset). If you have a suggestion for a dedicated icon for this, we can think about this again, though.

---

speed table

this bug is now fixed in 2eabf49

---

crossing=island […] Selecting an option suggested in the dropdown shouldn't result in tagging that iD considers outdated

I can't fully reproduce this issue, because the value is not suggested in the field's dropdown: iD filters out all tag values which are marked as deprecated, like this one.

For cases where this value is found in existing data, or entered manually, this is to my understanding working as intended. See https://wiki.openstreetmap.org/wiki/Key:crossing#Other_used:

Use crossing:island=yes in preference; in addition to crossing=traffic_signals/uncontrolled/unmarked.

---

changing the type of a crossing to crossing=no [should] remove highway=crossing

kind of fixed in bd1dd8f: iD now suggests to remove the highway=crossing tag when choosing the no value in the dropdown. I know this is is not quite the most elegant way to implement this from a user experience point of view, but I think it is OK in this case, because it is quite an uncommon/special thing to do.