Skip to content

Update public_bookcase.json - Add more fields #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 5 commits into from
Dec 16, 2023
Merged

Update public_bookcase.json - Add more fields #1001

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
415ff6f
Update public_bookcase.json - Add more fields
danieldegroot2 Sep 9, 2023
63e5efc
Create books.json
danieldegroot2 Sep 12, 2023
b2b3b8f
Update public_bookcase.json
danieldegroot2 Sep 12, 2023
59b19ed
reorder fields slightly
tyrasd Dec 16, 2023
fb836fe
more precise label, allow multiple values
tyrasd Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions data/fields/books.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"key": "books",
"type": "combo",
Comment thread
tyrasd marked this conversation as resolved.
Outdated
"label": "Type"
}
7 changes: 6 additions & 1 deletion data/presets/amenity/public_bookcase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,28 @@
"fields": [
"name",
"public_bookcase/type",
"books",
Copy link
Copy Markdown
Member

@tyrasd tyrasd Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have said that for public bookcases, it is rather the exception to find only specific types of books. For this reason, I would have put this field to the moreFields section.

Copy link
Copy Markdown
Contributor Author

@danieldegroot2 danieldegroot2 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already exception they are mapped, let alone such tags being discovered by users, but it is fine to change it.

"operator",
"capacity",
"lit"
Copy link
Copy Markdown
Member

@tyrasd tyrasd Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lit tag seems to be a relatively popular combination (see taginfo: https://taginfo.openstreetmap.org/tags/amenity=public_bookcase#combinations). Why hide it?

Copy link
Copy Markdown
Contributor Author

@danieldegroot2 danieldegroot2 Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, it is moved to moreFields. (it is not hidden if people can easily discover it)
I think it is overall more of an exception they are lit, although relatively popular now.
Similarly, I think it is exception people will use a bookcase at night (except in areas with longer nights).
Otherwise I also don't think it is significant property of object itself, like for advertising (only on few ones on public squares).

(Here also it is fine to change it.)

"direction"
Copy link
Copy Markdown
Member

@tyrasd tyrasd Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction tag is not used very commonly on public bookcases. What's the intention behind offering the field by default for these features?

Copy link
Copy Markdown
Contributor Author

@danieldegroot2 danieldegroot2 Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it can be more easily discovered.
direction in general is not often used, because it is not directly a object/access type.
However, it is often found on/near barrier and usually only accesible from one side.
It is recommended to add direction to such objects to prevent ambiguity with its position relative to other objects.
(similar to cameras, defibrillators, etc.)

(Here also it is fine to change it.)

],
"moreFields": [
"access_simple",
"address",
"branch_brand",
"brand",
"colour",
"covered",
"email",
"height",
"indoor",
"level",
"lit",
"location",
"opening_hours",
"phone",
"ref",
"support",
"wheelchair"
],
"geometry": [
Expand Down
⚡