Skip to content

Add translatable strings to bridge field#1002

Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom
kjonosm:patch-39
Feb 26, 2024
Merged

Add translatable strings to bridge field#1002
tyrasd merged 1 commit intoopenstreetmap:mainfrom
kjonosm:patch-39

Conversation

@kjonosm
Copy link
Copy Markdown
Contributor

@kjonosm kjonosm commented Sep 9, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-1002--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@kjonosm
Copy link
Copy Markdown
Contributor Author

kjonosm commented Feb 11, 2024

Hi @tyrasd, would you be able to review this pr?

@tyrasd tyrasd added the new-value adds value(s) to existing field label Feb 26, 2024
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Feb 26, 2024

Thank you, this looks good to me. It's only a bit unfortunate that this only applies to the Bridge Type field for the preset man_made=bridge and not for for selecting the type of bridge in the structure field which is used on all highway presets for example. That would need to be addressed separately, however, as it would involve adjusting some code in iD and likely also the tagging schema's json schema.

@tyrasd tyrasd merged commit 9b7e616 into openstreetmap:main Feb 26, 2024
@kjonosm kjonosm deleted the patch-39 branch February 26, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-value adds value(s) to existing field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants