Add presets for marsh, swamp and reedbed#113
Closed
Bertware wants to merge 1 commit intoopenstreetmap:mainfrom
Closed
Add presets for marsh, swamp and reedbed#113Bertware wants to merge 1 commit intoopenstreetmap:mainfrom
Bertware wants to merge 1 commit intoopenstreetmap:mainfrom
Conversation
TurnrDev
approved these changes
Feb 20, 2021
mbrzakovic
suggested changes
Nov 10, 2021
Collaborator
mbrzakovic
left a comment
mbrzakovic
left a comment
There was a problem hiding this comment.
This change is justified given that all 3 types are approved and have substantial usage in osm.
I noticed that the list of allowed geometries for these types (and wetland) includes points, while the wiki discourages such usage, and josm only allows areas.
Curious on the reasoning behind this.
Member
|
merged as f47186e (including the geometry type fix proposed by @mbrzakovic above) |
Contributor
Author
|
Sorry, I completely forgot to fix the geometry, agree with @mbrzakovic that points did not have to be included. Thanks for fixing and merging @tyrasd! |
k-yle
pushed a commit
that referenced
this pull request
Mar 19, 2026
Bumps [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest) from 29.1.1 to 29.7.0. - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v29.7.0/packages/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add presets for marsh, swamp and reedbed. This makes it significantly easier to map areas with wetlands as they become easier to find (=easier for new mappers) and they'll be suggested as individual types in the iD editor, meaning you can set them with one click instead of having to define the wetland type over and over. Reedbed is a lesser-used wetland type (5%, 52k tags) but is common, and making it easier to find could boost correct usage as well.
https://wiki.openstreetmap.org/wiki/Tag:wetland%3Dmarsh
https://wiki.openstreetmap.org/wiki/Tag:wetland%3Dswamp
https://wiki.openstreetmap.org/wiki/Tag:wetland%3Dreedbed