Skip to content

Add presets for ski jump tagging#1176

Merged
tordans merged 5 commits intoopenstreetmap:mainfrom
olafkryus:ski-jumping
Jul 8, 2024
Merged

Add presets for ski jump tagging#1176
tordans merged 5 commits intoopenstreetmap:mainfrom
olafkryus:ski-jumping

Conversation

@olafkryus
Copy link
Copy Markdown
Contributor

Added most important presets for ski jumping venue tagging – the in-run structure, the piste and the take-off edge.

@github-actions
Copy link
Copy Markdown

🍱 You can preview the tagging presets of this pull request here.

Comment thread data/presets/man_made/ski_jump.json Outdated
"tags": {
"man_made": "ski_jump"
},
"name": "Ski Jumping Hill Structure / In-Run Tower"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this could be slightly shortened to the following?

Suggested change
"name": "Ski Jumping Hill Structure / In-Run Tower"
"name": "Ski Jumping In-Run/Tower"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in most of the cases it is true that man-made part is equal to the in-run tower.
It is also not uncommon for the man-made structure to include more than the in-run itself if the terrain is too flat (e.g.: Holmenkollen).
There are also ski jumps on slopes that happen to be just right (e.g. as seen here) and whether they really qualify as "man-made" (or "tower") is debatable.
If shortening of this (quite long I agree) name is desired, I would rather opt for Ski Jumping Hill Structure.

Comment thread data/presets/man_made/ski_jump.json
Comment thread data/presets/man_made/ski_jump.json Outdated
tyrasd

This comment was marked as resolved.

olafkryus and others added 2 commits April 1, 2024 00:58
@olafkryus
Copy link
Copy Markdown
Contributor Author

Thanks, this looks quite good already. See a few suggestions inline.

Thanks for the feedback.
I've applied one patch, and provided more info on the other – please be the judge ;)

In addition, could you also add the option for ski_jumping to the sport field please?

Sure. Done: e2f42db

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jul 6, 2024

I just reran the actions to the preview is there again.

List of examples cases: https://overpass-turbo.eu/s/1NO4

The last open issue from above was the naming. I agree it should be shorter. It is two lines now and hard to understand:

image

Please move relevant search terms to the aliases or terms https://github.com/ideditor/schema-builder?tab=readme-ov-file#preset-schema

Please also check if the OSM Wikidata item can be improved to better explain the tag usage (its in the screenshot).
Here: https://wiki.openstreetmap.org/wiki/Item:Q16841

One thing I am unclear about is the tagging as area vs. line.

However when mapped as a line…

  • there is an error to remove tags
  • the preset does not apply
  • the help text and icon is different
image

Examples:

Another thing is, why the piste:type is not a field when using like https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w187922757&locale=en&map=19.94/47.89814/8.11134 – Is this tagging wrong or is the field missing?

tordans

This comment was marked as duplicate.

@olafkryus
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback.

The last open issue from above was the naming. I agree it should be shorter. It is two lines now and hard to understand

I've changed it now to a simple "Ski Jumping Tower". I hope the additional info will be enough for the more unusual cases.

(I've also went with it and shortened "Ski Jumping Hill Take-Off Point" to just "Ski Jumping Take-Off")

Please move relevant search terms to the aliases or terms

I've made some changes to that, I hope they are in-line with what was expected.

Please also check if the OSM Wikidata item can be improved to better explain the tag usage

I've reworded descriptions for both Q16841 and Q21202, I hope they are a bit more clear now.

One thing I am unclear about is the tagging as area vs. line

Another thing is, why the piste:type is not a field when using like https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w187922757&locale=en&map=19.94/47.89814/8.11134 – Is this tagging wrong or is the field missing?

As for the tagging:

  • piste:type=ski_jump is supposed to span the whole of the "piste", the path the athlete travels, so that would be from the very top of the in-run to the very end of the out-run at the bottom. A piste can be tagged either as a line following the "path" of travel, or as an outline of the whole area available to the athlete.
  • man_made=ski_jump is supposed to cover only the outline of the man-made structure. So most of the time it will cover only the outline of the in-run tower, or it will be omitted completely if the ski jumping hill is "natural" (the in-run follows the curve of a fortunately shaped slope)

Therefore, it follows that, in almost all of the cases, the above two tags should be applied to separate elements.

So, the examples provided above seem to be wrongly tagged, and that seems to be the source of the mentioned problems.

I hope the link below will serve as a better example (and a more interesting, informative one, since the situation is more complex as the out-run doubles as a football pitch in the summer):

https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w1223388311&locale=en&map=18/47.32155/11.17741

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jul 7, 2024

As for the tagging: (…)
Therefore, it follows that, in almost all of the cases, the above two tags should be applied to separate elements.
So, the examples provided above seem to be wrongly tagged, and that seems to be the source of the mentioned problems.

Thanks for explaining, @olafkryus. I wonder what the best way to handle this would be. Would you be up for creating a MapRoulette Challenge for those mistagged features, so the data gets fixed? My concern is that iD will display this very prominent message, but the actions on the message are wrong. And AFAIK, it is not easy to change those messages because they are autogenerated…

@olafkryus
Copy link
Copy Markdown
Contributor Author

I wonder what the best way to handle this would be. Would you be up for creating a MapRoulette Challenge for those mistagged features, so the data gets fixed? My concern is that iD will display this very prominent message, but the actions on the message are wrong.

@tordans: Fortunately, there were "only" about a few dozen of such cases worldwide, therefore I decided to fix them all on my own on a case-by-case basis.

So, it shouldn't be an issue anymore: https://overpass-turbo.eu/s/1NRb

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jul 8, 2024

Fortunately, there were "only" about a few dozen of such cases worldwide, therefore I decided to fix them all on my own on a case-by-case basis.

Lucky me to pick two of them right away :-D. Thanks for the cleanup!


I think this looks good now and ready to be merged.

@tordans tordans merged commit f7622e3 into openstreetmap:main Jul 8, 2024
@tordans tordans added the add-field add existing field to more entries, for field creation see new-field label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field new-preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants