Add cycleway:lane:SIDE where cycleway:SIDE is present

[tordans]

Test out support for https://wiki.openstreetmap.org/wiki/Key:cycleway:lane.

This is part of #1164.

---

This is a draft for now to experiment via Preview with different ways to model this in the existing schema.

We might want to use a directionalCombo for this. However, that would suggest to tag data for cycleway:left:lane=* when in fact there is no cycleway:left=lane. This tries to work around this by adding separate fields with re-conditions.

Another solution for this would be ideditor/schema-builder#153.

[github-actions]

🍱 You can preview the tagging presets of this pull request here.

[tordans]

Testing

"cycleway:right:lane"="advisory"

• https://overpass-turbo.eu/s/1KTM
• way/172243640
• https://pr-1209--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w172243640&locale=en&map=17.55/52.42423/13.45225
• 

"cycleway:both:lane"="advisory"

• https://overpass-turbo.eu/s/1KTN
• way/1228412242
• https://pr-1209--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w1228412242&locale=en&map=20.00/52.45548/13.58080
• the cycleway:both=lane is not visible due to Deprecate cycleway for cycleway:both #1137

Left/right different

• https://pr-1209--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w1169045892&locale=en&map=20.00/52.46048/13.49430
• 

More fields

• Fields are not present here; probably due to the allowedTags condition
• 

More fields shows up

It does show up if the conditions match.

• https://pr-1209--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w1044393274&locale=en&map=20.00/52.44538/13.38242
• 

[tordans]

Next steps

• Solve the cyclway:both=* and cycleway=* issue in the prerequisiteTag; do we need to add another field for this?
• Probably add a readme to the folder that explains the weird setup.
• Move from moreFields to fields so users are nudged to add the data
• Add "undefined" option to dropdown
• Double check highway presets (any missing?)
• Extract into @template from highway presets
• Update wording "Left Bike Lane Type" (because "Bike Lanes" is the directionalCombo)

[matkoniecz]

@tordans do you plan to do those steps?

Is anyone else interested in doing those?

Or should we close this PR around second anniversary of the last activity? (or fourth or third? probably second)

[tordans]

In one of the meetups we talke about this or something similar for parking where we said that the logic to only show a sub-tag (cycleway:SIDE:lane) to show up when a specific tag is given (cycleway:SIDE=lane) should be part of the logic in iD that handles the directional combo component.

I wanted to look into this. However, given that my PRs in iD are still pending on the sidewalk part (which also touches the directional combo) I will not do so until there is activity over there.

We can, however, close this draft as something that is likely not the right approach.