Skip to content

Add cycle_barrier fields#1232

Merged
tyrasd merged 4 commits intoopenstreetmap:mainfrom
k-yle:cycle_barrier
Feb 13, 2025
Merged

Add cycle_barrier fields#1232
tyrasd merged 4 commits intoopenstreetmap:mainfrom
k-yle:cycle_barrier

Conversation

@k-yle
Copy link
Copy Markdown
Collaborator

@k-yle k-yle commented May 25, 2024

Note

This is a draft PR because it's blocked by ideditor/schema-builder#87. Once that PR is merged, the temporary override to package.json needs to be removed. Edit: the new syntax has been removed and can be added once ideditor/schema-builder#87 is released

This PR adds a field to the barrier=cycle_barrier preset to specify the type of barrier, and adds the wheelchair tag.

Depending on which barrier type is chosen, other fields like maxwidth:physical are shown. The logic is documented on this wiki page.

@github-actions
Copy link
Copy Markdown

🍱 You can preview the tagging presets of this pull request here.

@k-yle
Copy link
Copy Markdown
Collaborator Author

k-yle commented May 25, 2024

The preview link above won't work, since it's using the package.json from the main branch, for security reasons. An alternative preview is available here.

@tordans tordans marked this pull request as draft June 5, 2024 18:52
@k-yle k-yle mentioned this pull request Nov 13, 2024
@Zverik
Copy link
Copy Markdown
Collaborator

Zverik commented Nov 13, 2024

After #1385, I see an issue with spacing, overlap, and opening fields: they are meant to contain only metric values, so their type should be number, and they need (m) in labels.

@k-yle k-yle marked this pull request as ready for review November 13, 2024 13:46
@k-yle
Copy link
Copy Markdown
Collaborator Author

k-yle commented Nov 13, 2024

@Zverik I've removed the syntax that depends on the new schema, so this PR is no longer blocked.

I've also removed support for feet & inches - but it's worth noting that the wiki is currently inconsistent: the English documentation allows other units like feet/inches12, but the german document does not3

Footnotes

  1. https://osm.wiki/Key:opening

  2. https://osm.wiki/Key:width

  3. https://osm.wiki/DE:Key:opening

@tyrasd tyrasd merged commit c156fca into openstreetmap:main Feb 13, 2025
@tyrasd tyrasd added new-field create a new field (see add-field for cases where field from presets is added to new entries) add-field add existing field to more entries, for field creation see new-field and removed new-preset labels Feb 13, 2025
@k-yle k-yle deleted the cycle_barrier branch February 21, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field new-field create a new field (see add-field for cases where field from presets is added to new entries)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants