Merged
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
Collaborator
Author
|
The preview link above won't work, since it's using the package.json from the |
Closed
Collaborator
|
After #1385, I see an issue with |
Collaborator
Author
|
@Zverik I've removed the syntax that depends on the new schema, so this PR is no longer blocked. I've also removed support for feet & inches - but it's worth noting that the wiki is currently inconsistent: the English documentation allows other units like feet/inches12, but the german document does not3 Footnotes |
Zverik
approved these changes
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a draft PR because it's blocked by ideditor/schema-builder#87. Once that PR is merged, the temporary override to package.json needs to be removed.Edit: the new syntax has been removed and can be added once ideditor/schema-builder#87 is releasedThis PR adds a field to the
barrier=cycle_barrierpreset to specify the type of barrier, and adds thewheelchairtag.Depending on which barrier type is chosen, other fields like
maxwidth:physicalare shown. The logic is documented on this wiki page.