Skip to content

allow several presets to be mapped as vertices #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tordans merged 1 commit into from
Jul 10, 2024
Merged

allow several presets to be mapped as vertices #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion data/presets/amenity/ticket_validator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"support"
],
"geometry": [
"point"
"point",
"vertex"
Comment thread
tyrasd marked this conversation as resolved.
],
"tags": {
"amenity": "ticket_validator"
Expand Down
3 changes: 2 additions & 1 deletion data/presets/man_made/fuel_pump.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"self_service"
],
"geometry": [
"point"
"point",
"vertex"
Comment thread
k-yle marked this conversation as resolved.
],
"terms": [
"petrol",
Expand Down
1 change: 1 addition & 0 deletions data/presets/man_made/mineshaft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"icon": "temaki-mineshaft_cage",
"geometry": [
"point",
"vertex",
Comment thread
k-yle marked this conversation as resolved.
"area"
],
"fields": [
Expand Down
3 changes: 2 additions & 1 deletion data/presets/marker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"manufacturer"
],
"geometry": [
"point"
"point",
"vertex"
Comment thread
tyrasd marked this conversation as resolved.
],
"terms": [
"identifier",
Expand Down
1 change: 1 addition & 0 deletions data/presets/natural/sinkhole.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
],
"geometry": [
"point",
"vertex",
"area"
Comment thread
tyrasd marked this conversation as resolved.
],
"tags": {
Expand Down
1 change: 1 addition & 0 deletions data/presets/public_transport/station_light_rail.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
],
"geometry": [
"point",
"vertex",
Copy link
Copy Markdown
Collaborator

@tordans tordans Jul 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK…

My -1: The wiki sounds like we want those to be bigger areas. And there is presets/public_transport/platform/_light_rail_point.json which sounds more like the thing one wants to glue to a railway way?

My +1: There are other presets that have the vertex already. Why is this so inconsistent…?

  • station_aerialway.json has it
  • station_bus.json doesn't
  • station_ferry.json has it
  • station_light_rail.json doesn't (yet)
  • station_monorail.json doesn't
  • station_subway.json doesn't
  • station_train.json has it
  • station_tram.json doesn't
  • station_trolleybus.json doesn't
  • station.json doesn't

I did not do any analysis how this is used because I lack the tooling to do this quickly.

Copy link
Copy Markdown
Collaborator Author

@k-yle k-yle Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I proposed this change was less about the tagging style and more about the inconsistency:

Screen.Recording.2024-07-09.215053.mp4

If you drag a Light Rail Station onto a way, then the preset degenerates down to Train Station, which is pretty confusing. So ideally, all these presets would be allowed as verticies, or none of them.

I did not do any analysis how this is used because I lack the tooling to do this quickly.

Here's an overpass query to compare points vs vertices. There might be a more efficient query, but I'm not an overpass expert

"area"
],
"tags": {
Expand Down
1 change: 1 addition & 0 deletions data/presets/public_transport/station_monorail.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
],
"geometry": [
"point",
"vertex",
"area"
],
"tags": {
Expand Down
1 change: 1 addition & 0 deletions data/presets/public_transport/station_subway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
],
"geometry": [
"point",
"vertex",
"area"
],
"tags": {
Expand Down
3 changes: 2 additions & 1 deletion data/presets/tourism/information/board/welcome_sign.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"icon": "maki-embassy",
"geometry": [
"point"
"point",
"vertex"
Comment thread
tyrasd marked this conversation as resolved.
],
"terms": [
"new location"
Expand Down
⚡