Skip to content

Include more countries for Footwear Decontamination Station preset#1335

Open
arch0345 wants to merge 4 commits intoopenstreetmap:mainfrom
arch0345:footwear_decontamination
Open

Include more countries for Footwear Decontamination Station preset#1335
arch0345 wants to merge 4 commits intoopenstreetmap:mainfrom
arch0345:footwear_decontamination

Conversation

@arch0345
Copy link
Copy Markdown
Contributor

@arch0345 arch0345 commented Sep 4, 2024

Description, Motivation & Context

This will prevent iD from erroneously flagging points tagged with man_made=footwear decontamination as invalid.
image

These stations are pretty common at trailheads in the PNW
image

I also added 'boot brush' as a term

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2024

🍱 You can preview the tagging presets of this pull request here.

Copy link
Copy Markdown
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the iD warning - this seems like a bug that should be fixed, regardless of whether this PR is accepted. Right now, it's not allowed as a point nor an area 😆

The parent preset (man_made=*) is supposed to allow any geometry:

"geometry": [
"point",
"vertex",
"line",
"area"
],

Comment thread data/presets/man_made/footwear_decontamination-AU-NZ.json
@matkoniecz
Copy link
Copy Markdown
Collaborator

As I understand problem that this PR tried to fix was resolved by openstreetmap/iD#10459 - right?

In such case reason for its existence seems gone.

@k-yle
Copy link
Copy Markdown
Collaborator

k-yle commented Oct 31, 2025

As I understand problem that this PR tried to fix was resolved by openstreetmap/iD#10459 - right?

yes

In such case reason for its existence seems gone

it seems like there's now a few mapped in the US, @arch0345 do you still think it's worth removing the regional restriction? or perhaps adding the US to the list of countries?

@arch0345
Copy link
Copy Markdown
Contributor Author

arch0345 commented Nov 1, 2025

Yeah I think it'll still be worth removing the regional restriction for this preset. It would be quite useful to have when mapping hiking areas. I've also encountered some in Canada and Korea a few years back, not sure how prevalent these are in other parts of the world though.

@matkoniecz
Copy link
Copy Markdown
Collaborator

in #1235 @tordans asked it to be area-limited

It makes it easier to have a good UX when less relevant options are not present for other countries (and easy to fix later). I would rather think we should limit the other preset to countries that are relevant.

for

not sure how prevalent these are in other parts of the world though.

I never seen one in my entire life.

I've also encountered some in Canada and Korea a few years back

maybe instead make PR adding those areas?

@k-yle
Copy link
Copy Markdown
Collaborator

k-yle commented Nov 1, 2025

maybe instead make PR adding those areas?

if we go with this option, I suggest also adding SG, ID, and HK where I've seen them too

@arch0345 arch0345 changed the title Remove regional restriction for Footwear Decontamination Station preset Include more countries for Footwear Decontamination Station preset Nov 2, 2025
Copy link
Copy Markdown
Contributor

@FloEdelmann FloEdelmann Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, NSI does not use the preset, so the rename won't be as chaotic as openstreetmap/iD#11527 , but it will still create extra work for translators unfortunately.

so we probably don't need a placeholder preset for this case?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, kyle. And our process is still to change the filenames, so I think we should continue following this process.

"contamination station",
"decontamination station"
"decontamination station",
"boot brush"
Copy link
Copy Markdown
Contributor

@FloEdelmann FloEdelmann Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matkoniecz
Copy link
Copy Markdown
Collaborator

note

This branch has conflicts that must be resolved

(and I am neither maintainer nor PR author so I cannot resolve them, as I have no write permission on the branch)

@k-yle k-yle removed their assignment Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants