Include more countries for Footwear Decontamination Station preset#1335
Include more countries for Footwear Decontamination Station preset#1335arch0345 wants to merge 4 commits intoopenstreetmap:mainfrom
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
k-yle
left a comment
There was a problem hiding this comment.
Regarding the iD warning - this seems like a bug that should be fixed, regardless of whether this PR is accepted. Right now, it's not allowed as a point nor an area 😆
The parent preset (man_made=*) is supposed to allow any geometry:
id-tagging-schema/data/presets/man_made/_yes.json
Lines 8 to 13 in 6d86393
|
As I understand problem that this PR tried to fix was resolved by openstreetmap/iD#10459 - right? In such case reason for its existence seems gone. |
yes
it seems like there's now a few mapped in the US, @arch0345 do you still think it's worth removing the regional restriction? or perhaps adding the US to the list of countries? |
|
Yeah I think it'll still be worth removing the regional restriction for this preset. It would be quite useful to have when mapping hiking areas. I've also encountered some in Canada and Korea a few years back, not sure how prevalent these are in other parts of the world though. |
|
in #1235 @tordans asked it to be area-limited
for
I never seen one in my entire life.
maybe instead make PR adding those areas? |
if we go with this option, I suggest also adding |
There was a problem hiding this comment.
Not sure if renaming this file should be done in two steps like newly described here?
There was a problem hiding this comment.
in this case, NSI does not use the preset, so the rename won't be as chaotic as openstreetmap/iD#11527 , but it will still create extra work for translators unfortunately.
so we probably don't need a placeholder preset for this case?
There was a problem hiding this comment.
I agree, kyle. And our process is still to change the filenames, so I think we should continue following this process.
| "contamination station", | ||
| "decontamination station" | ||
| "decontamination station", | ||
| "boot brush" |
There was a problem hiding this comment.
Please keep the search terms ordered alphabetically, see https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset
|
note
(and I am neither maintainer nor PR author so I cannot resolve them, as I have no write permission on the branch) |
Description, Motivation & Context
This will prevent iD from erroneously flagging points tagged with

man_made=footwear decontaminationas invalid.These stations are pretty common at trailheads in the PNW

I also added 'boot brush' as a term