Add address field to amenity=parcel_locker in HU#1338
Add address field to amenity=parcel_locker in HU#1338gy-mate wants to merge 4 commits intoopenstreetmap:mainfrom
address field to amenity=parcel_locker in HU#1338Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
note that many are incorrectly added
nope at least in Poland they state closest address, which is not address of the parcel locker |
|
I would be against further encouraging such bad tagging, unless it is actually correct tagging more often than not |
@matkoniecz This may be the case in Poland but not in Germany (https://www.dhl.de/de/privatkunden/dhl-standorte-finden.html), Czechia (https://www.rohlik.cz/tema/rohlikpoint), Slovakia (https://www.alza.sk/alzabox#kde-najdes-svoj-alzabox) or Hungary (https://wiki.openstreetmap.org/wiki/Hungary/Jelölési_példák#Csomagautomata). The @ITineris said the following about this on the OSM Hungary Matrix server, which I agree with:
|
|
@vasony also mentioned that "the So these might be two different information. I think that iD could help users wanting to add the address by showing an Address moreField. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I have no knowledge on address data for this POIs outside Poland. I agree with
and AFAIK you can make it so it will appear in some regions and in some not, but I have no idea how to do this |
address field to amenity=parcel_lockeraddress field to amenity=parcel_locker in HU
@matkoniecz I've changed the |
|
@tordans Could you please review this PR? Many thanks in advance! |
tordans
left a comment
There was a problem hiding this comment.
I am hesitant with regional presets. The discussion however sounds good to me.
Will wait for more input and put it on the agenda of the community meet to get some quick feedback.
@gy-mate accidentally left it there. Co-authored-by: Tobias <t@tobiasjordans.de>
This comment was marked as outdated.
This comment was marked as outdated.
We only talked about this very briefly in https://wiki.openstreetmap.org/wiki/ID/Community_Chats/2025#Agenda_/_Notes_2 but the gist was that we should use regional presets when needed.
https://taginfo.geofabrik.de/europe:hungary/tags/amenity=parcel_locker#combinations is a good comparison, it shows ~70%+ of |
|
@gy-mate could you double check the test comment after the latest changes. I expected https://pr-1338--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&locale=en&map=21.51/47.58592/19.04546&id=n12118214705 to show the address, right? Nothing jumped out to me when looking at the code or https://github.com/ideditor/schema-builder?tab=readme-ov-file#fieldsmorefields … |
|
@tordans Is it possible to cross-reference |
https://github.com/ideditor/schema-builder?tab=readme-ov-file#name sounds like maybe only |
|
I've removed the @tordans Could you please give me some further help? Many thanks in advance!! |
|
@k-yle do you have an idea why the address does not show? |
|
@tordans short answer: If you remove the long answer: the example node has a NSI's presets are derived from a released version of id-tagging-schema. not sure how often the NSI team update their version of the tagging schema, but the system seems to work for existing regional presets. |
k-yle
left a comment
There was a problem hiding this comment.
from a technical persepective this looks good, I'll let others discuss whether a regional preset is appropriate here
@matkoniecz Would this regional preset be fine with you? |
|
I am still suspicious about it (some people claimed that parcel lockers have addresses in Poland - in reality they list closest existing address), but I lack local knowledge to confirm that suspicion. Hmm, I guess that one may check existing data is it just listing closest real address. |
|
@matkoniecz I have to correct my previous comment: the address of parcel lockers in Hungary is actually the address closest to them. But parcels delivered there are addressed to that address (it's written on parcels). So it's a mix of the two. We import Hungarian parcel lockers with So I think it's beneficial to add these addresses to parcel lockers, hence my PR. I couldn't find anything on https://wiki.openstreetmap.org/wiki/Addresses that would be against this. I also checked if we could use https://wiki.openstreetmap.org/wiki/Key:object:* instead, but it says it's "Used to describe the position of man-made features where nothing will be delivered at." so it doesn't seem like a viable option to me. |
|
@matkoniecz I think we have enough buy in (1, 2) here to go down this route. Should there be negative feedback later, we can always circle back. Unless you 👎 I would merge in a few days. |
|
I am still against putting claimed address on something where it is not its address. I do not want to run with https://en.wikipedia.org/wiki/Liberum_veto but I still think this one is a mistake. |
@matkoniecz Are you against adding addresses to parcel lockers at all, or do you dislike using the |
|
I think that if it really needs to be added it would be better to use a different keys. But that is just my opinion. |
|
Which keys would you suggest instead? |
|
https://wiki.openstreetmap.org/wiki/Key:object:* seems to be used for those
|
|
|
Oh, that is only in infobox summary - despite not being present in article, But note entire one:
in this case things are not delivered to this address - they are delivered to object referenced otherwise, with address only stated to help customers find it. Maybe this description can be adjusted? But that would require discussion, I guess |
|
I asked at https://wiki.openstreetmap.org/wiki/User_talk:MalgiK#object%3A%2A for start to check what is the source of this claim. |
|
Thank you! :) |
|
The Hungarian community agreed upon using Thank you for your thorough guidance, @matkoniecz! :) |

Description, Motivation & Context
amenity=parcel_lockers often have an address associated with them. This is usually available on the operator's website.Related issues
None.
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:

https://taginfo.openstreetmap.org/tags/amenity=parcel_locker#combinations
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.