Skip to content

Add address field to amenity=parcel_locker in HU#1338

Closed
gy-mate wants to merge 4 commits intoopenstreetmap:mainfrom
gy-mate:patch-1
Closed

Add address field to amenity=parcel_locker in HU#1338
gy-mate wants to merge 4 commits intoopenstreetmap:mainfrom
gy-mate:patch-1

Conversation

@gy-mate
Copy link
Copy Markdown
Contributor

@gy-mate gy-mate commented Sep 7, 2024

Description, Motivation & Context

amenity=parcel_lockers often have an address associated with them. This is usually available on the operator's website.

Related issues

None.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/amenity=parcel_locker#combinations
Screenshot 2024-09-07 at 13 16 12

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 7, 2024

🍱 You can preview the tagging presets of this pull request here.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 7, 2024

@matkoniecz
Copy link
Copy Markdown
Collaborator

Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/amenity=parcel_locker#combinations

note that many are incorrectly added

amenity=parcel_lockers often have an address associated with them. This is usually available on the operator's website.

nope

at least in Poland they state closest address, which is not address of the parcel locker

@matkoniecz
Copy link
Copy Markdown
Collaborator

I would be against further encouraging such bad tagging, unless it is actually correct tagging more often than not

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Nov 1, 2024

at least in Poland they state closest address, which is not address of the parcel locker

@matkoniecz This may be the case in Poland but not in Germany (https://www.dhl.de/de/privatkunden/dhl-standorte-finden.html), Czechia (https://www.rohlik.cz/tema/rohlikpoint), Slovakia (https://www.alza.sk/alzabox#kde-najdes-svoj-alzabox) or Hungary (https://wiki.openstreetmap.org/wiki/Hungary/Jelölési_példák#Csomagautomata). The amenity=parcel_locker wiki page also says that "Parcel lockers may have an official address".

@ITineris said the following about this on the OSM Hungary Matrix server, which I agree with:

If this is the case in Poland, do not use it there (if the two are different). But where it is, why not use it to help navigation?

@vasony also agrees with these.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Nov 1, 2024

@vasony also mentioned that "the branch=* is the actual branch which does not contain the full address. E.g. 'Bp. 11. ker. Mathias Corvinus Collegium', meanwhile the address is '1113 Budapest, Tas vezér utca 3-7. ' Both information are listed on the website [of the parcel locker operator]."

So these might be two different information. I think that iD could help users wanting to add the address by showing an Address moreField.

@gy-mate

This comment was marked as outdated.

@matkoniecz

This comment was marked as outdated.

@gy-mate

This comment was marked as outdated.

@matkoniecz
Copy link
Copy Markdown
Collaborator

I have no knowledge on address data for this POIs outside Poland. I agree with

If this is the case in Poland, do not use it there (if the two are different).

and AFAIK you can make it so it will appear in some regions and in some not, but I have no idea how to do this

@gy-mate gy-mate changed the title Add address field to amenity=parcel_locker Add address field to amenity=parcel_locker in HU May 12, 2025
@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented May 12, 2025

AFAIK you can make it so it will appear in some regions and in some not

@matkoniecz I've changed the address field to only appear in Hungary. Other countries can be added later by the local communities.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented May 31, 2025

@tordans Could you please review this PR? Many thanks in advance!

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hesitant with regional presets. The discussion however sounds good to me.

Will wait for more input and put it on the agenda of the community meet to get some quick feedback.

Comment thread data/presets/amenity/parcel_locker.json Outdated
@gy-mate accidentally left it there.

Co-authored-by: Tobias <t@tobiasjordans.de>
@gy-mate

This comment was marked as outdated.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jun 29, 2025

I am hesitant with regional presets. Will wait for more input and put it on the agenda of the community meet to get some quick feedback.

We only talked about this very briefly in https://wiki.openstreetmap.org/wiki/ID/Community_Chats/2025#Agenda_/_Notes_2 but the gist was that we should use regional presets when needed.


Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/amenity=parcel_locker#combinations

https://taginfo.geofabrik.de/europe:hungary/tags/amenity=parcel_locker#combinations is a good comparison, it shows ~70%+ of addr:* tags in combination with the primary tag.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jun 29, 2025

@gy-mate could you double check the test comment after the latest changes. I expected https://pr-1338--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&locale=en&map=21.51/47.58592/19.04546&id=n12118214705 to show the address, right?

Nothing jumped out to me when looking at the code or https://github.com/ideditor/schema-builder?tab=readme-ov-file#fieldsmorefields

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Jun 29, 2025

@tordans Is it possible to cross-reference terms and name to avoid duplication? Because I did that and maybe that's why the new parcel_locker-HU.json isn't included in the Netlify preview.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jun 30, 2025

@tordans Is it possible to cross-reference terms and name to avoid duplication?

https://github.com/ideditor/schema-builder?tab=readme-ov-file#name sounds like maybe only name should have the reference and terms and aliases removed, because name actually references both.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Jun 30, 2025

I've removed the terms cross-reference but the Netlify preview still doesn't show the address field. I have no idea what goes wrong, mainly because all tests and builds pass. :(

@tordans Could you please give me some further help? Many thanks in advance!!

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jun 30, 2025

@k-yle do you have an idea why the address does not show?

@k-yle
Copy link
Copy Markdown
Collaborator

k-yle commented Jun 30, 2025

@tordans short answer: If you remove the brand:* tags from that example node, it will show the new address field correctly.

long answer: the example node has a brand:wikidata tag, so iD is using the NSI preset, not the normal preset.

NSI's presets are derived from a released version of id-tagging-schema. not sure how often the NSI team update their version of the tagging schema, but the system seems to work for existing regional presets.

@gy-mate gy-mate requested a review from tordans June 30, 2025 13:29
@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Aug 17, 2025

So it's normal that the Netlify preview doesn't show the address field.

@tordans @k-yle Could you please re-review this PR? Many thanks in advance!

Copy link
Copy Markdown
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a technical persepective this looks good, I'll let others discuss whether a regional preset is appropriate here

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 12, 2025

I'll let others discuss whether a regional preset is appropriate here

@matkoniecz Would this regional preset be fine with you?

@matkoniecz
Copy link
Copy Markdown
Collaborator

I am still suspicious about it (some people claimed that parcel lockers have addresses in Poland - in reality they list closest existing address), but I lack local knowledge to confirm that suspicion.

Hmm, I guess that one may check existing data is it just listing closest real address.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 14, 2025

@matkoniecz I have to correct my previous comment: the address of parcel lockers in Hungary is actually the address closest to them. But parcels delivered there are addressed to that address (it's written on parcels). So it's a mix of the two.

We import Hungarian parcel lockers with osm_poi_matchmaker. As we also import their addresses, this improves house number coverage in rural areas by a lot. And that helps people who want to navigate to these addresses.

So I think it's beneficial to add these addresses to parcel lockers, hence my PR.

I couldn't find anything on https://wiki.openstreetmap.org/wiki/Addresses that would be against this. I also checked if we could use https://wiki.openstreetmap.org/wiki/Key:object:* instead, but it says it's "Used to describe the position of man-made features where nothing will be delivered at." so it doesn't seem like a viable option to me.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 14, 2025

@matkoniecz I think we have enough buy in (1, 2) here to go down this route. Should there be negative feedback later, we can always circle back. Unless you 👎 I would merge in a few days.

@tordans tordans added regional preset waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. labels Sep 14, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator

I am still against putting claimed address on something where it is not its address.

I do not want to run with https://en.wikipedia.org/wiki/Liberum_veto but I still think this one is a mistake.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 16, 2025

I am still against putting claimed address on something where it is not its address.

@matkoniecz Are you against adding addresses to parcel lockers at all, or do you dislike using the addr: prefix for this purpose?

@matkoniecz
Copy link
Copy Markdown
Collaborator

I think that if it really needs to be added it would be better to use a different keys.

But that is just my opinion.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 16, 2025

Which keys would you suggest instead?

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Sep 18, 2025

https://wiki.openstreetmap.org/wiki/Key:object:* seems to be used for those

The key object:*=* was used by several mechanical edits in Germany in 2015 and afterward, to add address information to small man-made features such as lamp posts and memorials, which had no address (addr:*=) that was given out by officials. The subkeys use the Karlsruher Schema. The main feature tags used were public artworks, memorials, control boxes for traffic light- and telecommunication systems which were not assigned an address, but near to an object having an official address tagged with addr:*=.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 18, 2025

@matkoniecz #1338 (comment):

I also checked if we could use https://wiki.openstreetmap.org/wiki/Key:object:* instead, but it says it's "Used to describe the position of man-made features where nothing will be delivered at." so it doesn't seem like a viable option to me.

@matkoniecz
Copy link
Copy Markdown
Collaborator

Oh, that is only in infobox summary - despite not being present in article, But note entire one:

Used to describe the position of man-made features where nothing will be delivered at. Address tagging for those features that shouldn't be tagged with the addr prefix.

in this case things are not delivered to this address - they are delivered to object referenced otherwise, with address only stated to help customers find it. Maybe this description can be adjusted? But that would require discussion, I guess

@matkoniecz
Copy link
Copy Markdown
Collaborator

I asked at https://wiki.openstreetmap.org/wiki/User_talk:MalgiK#object%3A%2A for start to check what is the source of this claim.

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Sep 19, 2025

Thank you! :)

@tyrasd tyrasd added waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on and removed waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. labels Nov 25, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator

@gy-mate
Copy link
Copy Markdown
Contributor Author

gy-mate commented Dec 15, 2025

The Hungarian community agreed upon using object:* instead of addr:* for parcel lockers so I'm closing this PR.

Thank you for your thorough guidance, @matkoniecz! :)

@gy-mate gy-mate closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preset regional waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants