Deprecated parking by tiptoptom · Pull Request #1390 · openstreetmap/id-tagging-schema

tiptoptom · 2024-11-17T11:50:39Z

Description, Motivation & Context

There was already a PR #918 about this. I'm willing to finish it now.

regarding add scheme to replace parking:lane:_side_=parallel/diagonal/perpendicular #918 (review) I added parking:lane::parallel=on_street
regarding add scheme to replace parking:lane:_side_=parallel/diagonal/perpendicular #918 (comment) and following I changed "lane" to "yes"

Related issues

Closes #879

Links and data

Relevant OSM Wiki links:

…

Relevant tag usage stats:

…

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

After you submit your PR, the system will create a preview and comment on your PR:

🍱 You can preview the tagging presets of this pull request here.
If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

github-actions · 2024-11-17T11:53:06Z

🍱 You can preview the tagging presets of this pull request here.

tordans

Lets remove those that are about below 1k as commented inline.
We have new guidelines on this in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#tag-updates-and-additions which don't have a strict number, but we want to only have entries here with relevant usage.

tordans · 2024-12-19T19:04:30Z

+    "replace": {"parking:both": "yes"}
+  },
+  {
+    "old": {"parking:lane:both": "no"},


🟢 43 724 https://taginfo.openstreetmap.org/search?q=parking%3Alane%3Aboth%3Dno

tordans · 2024-12-19T19:07:06Z

+  {
+    "old": {"parking:lane:both": "fire_lane"},
+    "replace": {"parking:both": "no", "parking:both:restriction": "no_stopping", "parking:both:restriction:reason": "fire_lane"}
+  },


🟡 671 https://taginfo.openstreetmap.org/tags/parking%3Alane%3Aboth=fire_lane

I think we can keep this (even though below 1k) because the new tagging is complex.

tordans · 2024-12-19T19:07:26Z

+    "replace": {"parking:both": "no", "parking:both:restriction": "no_stopping", "parking:both:restriction:reason": "fire_lane"}
+  },
+  {
+    "old": {"parking:lane:both": "separate"},


🟢 1k https://taginfo.openstreetmap.org/tags/parking%3Alane%3Aboth=separate

tordans · 2024-12-19T19:16:50Z

+    "replace": {"parking:right": "no", "parking:right:restriction": "no_stopping", "parking:right:restriction:reason": "fire_lane"}
+  },
+  {
+    "old": {"parking:lane:right": "separate"},


🟢 1k https://taginfo.openstreetmap.org/search?q=parking%3Alane%3Aright%3D+separate

tordans · 2024-12-19T19:17:03Z

+    "replace": {"parking:right": "separate"}
+  },
+  {
+    "old": {"parking:lane:right": "diagonal"},


🟢 3k https://taginfo.openstreetmap.org/search?q=parking%3Alane%3Aright%3D+diagonal

tordans · 2024-12-19T19:17:21Z

+    "replace": {"parking:right": "yes", "parking:right:orientation": "diagonal"}
+  },
+  {
+    "old": {"parking:lane:right": "parallel"},


🟢 34k https://taginfo.openstreetmap.org/search?q=parking%3Alane%3Aright%3D+parallel

tordans · 2024-12-19T19:17:39Z

+    "replace": {"parking:right": "yes", "parking:right:orientation": "parallel"}
+  },
+  {
+    "old": {"parking:lane:right": "perpendicular"},


🟢 6k https://taginfo.openstreetmap.org/search?q=parking%3Alane%3Aright%3D+perpendicular

tordans · 2024-12-19T19:18:04Z

+    "replace": {"parking:right": "yes", "parking:right:orientation": "perpendicular"}
+  },
+  {
+    "old": {"parking:lane:right:parallel": "on_street"},


🟢 8k https://taginfo.openstreetmap.org/search?q=parking%3Alane%3Aright%3Aparallel%3Don_street

tordans · 2024-12-19T19:22:34Z

@SupaplexOSM could you have a look at the tag update definitions – you will spot issues that might be there more easily than me.

Update: He messaged me with a "looks good at first glance"

tordans

I think this is good to be merged.

We could argue to remove the "parking:both": "yes" which is not the ideal migration scenario. In my migration tool https://osmberlin.github.io/osm-tag-updater/#/manual I did not use this migration path but instead told users to add the proper value. But we don't have this kind of tooling for iD easily available and the UI handles the case quite OK:

(Testlocation)

Migration info:

Which then shows as "unspecified" in the UI, which I think is OK:

I will merge this now in order to get it going and maybe improve upon it later.

This reverts commit 02d1552.

Samu__ and others added 7 commits May 13, 2023 12:29

icons deversified

d93e1ac

Merge branch 'openstreetmap:main' into main

6b90e61

deprecated parking:lane:*

c22b1db

Add some cases

9f70d4b

Merge branch 'openstreetmap:main' into deprecated_parking

6c66704

add parking:lane:<side>:parallel=on_street

a6af08d

changed "lane" to "yes"

b4b20ce

tordans requested changes Dec 19, 2024

View reviewed changes

Remove parking lane update entries with low usage

6ce9ee2

tordans added the deprecating label Dec 19, 2024

tordans self-assigned this Dec 19, 2024

tordans approved these changes Dec 20, 2024

View reviewed changes

tordans merged commit 02d1552 into openstreetmap:main Dec 20, 2024

tordans mentioned this pull request Apr 25, 2025

iD incorrectly tries to convert old to new parking scheme #1531

Closed

matkoniecz added a commit that referenced this pull request Dec 6, 2025

Revert "Add deprecation rules for parking:lane* (#1390)"

339977e

This reverts commit 02d1552.

matkoniecz mentioned this pull request Dec 6, 2025

Revert "Deprecated parking" #1849

Merged

Conversation

tiptoptom commented Nov 17, 2024

Description, Motivation & Context

Related issues

Links and data

Checklist and Test-Documentation Template

Uh oh!

github-actions bot commented Nov 17, 2024

Uh oh!

tordans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tordans commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tordans left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tordans commented Dec 19, 2024 •

edited

Loading