use same icon for shop=vacant as for disused:shop=*#1457
Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom Feb 27, 2025
Merged
use same icon for shop=vacant as for disused:shop=*#1457tyrasd merged 1 commit intoopenstreetmap:mainfrom
shop=vacant as for disused:shop=*#1457tyrasd merged 1 commit intoopenstreetmap:mainfrom
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
tyrasd
reviewed
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
shop=vacantpreset uses the generic "shop icon", even though a shop is whatshop=vacantis exactly not, it's the absence of a shop 😄!So, a more fitting icon is to use the same icon as for the preset for
disused:shop=*because these presets have a very similar meaning. In any case, both mean "there is currently no shop in this shop-space".The icon used by the disused-preset is https://fontawesome.com/icons/shop-slash
This also further mitigates #41.