Skip to content

Add Waterway Access Point preset and add fields to Slipway preset#1473

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
quincylvania:quincylvania/waterway-access-point
Jan 2, 2026
Merged

Add Waterway Access Point preset and add fields to Slipway preset#1473
tyrasd merged 3 commits intoopenstreetmap:mainfrom
quincylvania:quincylvania/waterway-access-point

Conversation

@quincylvania
Copy link
Copy Markdown
Collaborator

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2025

🍱 You can preview the tagging presets of this pull request here.

Comment thread data/presets/leisure/slipway.json
Comment thread data/presets/leisure/slipway.json
@tordans tordans added the field label Sep 14, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator

closing/reopening to refresh preview

@matkoniecz matkoniecz closed this Oct 21, 2025
@matkoniecz matkoniecz reopened this Oct 21, 2025
Comment thread data/presets/waterway/access_point.json
Comment thread data/presets/leisure/slipway.json Outdated
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cautious approval as I am not an expert on topic or tagging here

Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reuse the options from the access_simple field in all of the boat-specific access fields (and add "autoSuggestions": false). That way, the options are translated and recognizable. Or was there a specific reason to have them as generic combo fields that even allows free user input?

Comment thread data/presets/waterway/access_point.json
Comment thread data/presets/waterway/access_point.json
@matkoniecz
Copy link
Copy Markdown
Collaborator

@quincylvania Sorry for terribly slow PR review! But maybe you have or will have time to look at suggestions, for example about the icon?

@tyrasd tyrasd added the add-field add existing field to more entries, for field creation see new-field label Jan 2, 2026
tyrasd added 2 commits January 2, 2026 12:07
it's not a very common tag used in combination, and does not apply everywhere, so it's sufficient to keep it as an optional field only.
@tyrasd tyrasd merged commit fb1a814 into openstreetmap:main Jan 2, 2026
5 checks passed
@quincylvania quincylvania deleted the quincylvania/waterway-access-point branch January 5, 2026 14:33
@quincylvania
Copy link
Copy Markdown
Collaborator Author

@tyrasd @matkoniecz Thanks for seeing this through!

@matkoniecz
Copy link
Copy Markdown
Collaborator

@quincylvania I am confused by boat= field on leisure=slipway

It is not documented on https://wiki.openstreetmap.org/wiki/Key:boat and combination is rare at best according to https://taginfo.openstreetmap.org/tags/leisure=slipway#combinations

It is not mentioned at https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dslipway

that page has

For places without an accessible ramp where a boat (canoe/kayak/stand up paddleboard/row boat/paddle-craft) is carried to and from the water use waterway=access_point instead.

so leisure=slipway boat=no should not be a thing, right?

@quincylvania
Copy link
Copy Markdown
Collaborator Author

so leisure=slipway boat=no should not be a thing, right?

There are edge cases where this may be true. Some mappers/data users may assume that any slipway is a place you can launch a boat from a trailer but I'd contend that a slipway is just a piece of infrastructure. It might be used for things like wading, swimming, ice skating, fishing, or snowmobiling. It could be boat=no + canoe=designated to specify that only canoes are allowed to be launched. Here in NYC there are concrete ramps into ponds at parks that the public can hang out at but not use for boats, so these could be access=yes + boat=private.

In any case, boat is in moreFields and not fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants