Add Waterway Access Point preset and add fields to Slipway preset#1473
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
|
closing/reopening to refresh preview |
matkoniecz
left a comment
There was a problem hiding this comment.
cautious approval as I am not an expert on topic or tagging here
tyrasd
left a comment
There was a problem hiding this comment.
I would reuse the options from the access_simple field in all of the boat-specific access fields (and add "autoSuggestions": false). That way, the options are translated and recognizable. Or was there a specific reason to have them as generic combo fields that even allows free user input?
|
@quincylvania Sorry for terribly slow PR review! But maybe you have or will have time to look at suggestions, for example about the icon? |
it's not a very common tag used in combination, and does not apply everywhere, so it's sufficient to keep it as an optional field only.
|
@tyrasd @matkoniecz Thanks for seeing this through! |
|
@quincylvania I am confused by It is not documented on https://wiki.openstreetmap.org/wiki/Key:boat and combination is rare at best according to https://taginfo.openstreetmap.org/tags/leisure=slipway#combinations It is not mentioned at https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dslipway that page has
so |
There are edge cases where this may be true. Some mappers/data users may assume that any slipway is a place you can launch a boat from a trailer but I'd contend that a slipway is just a piece of infrastructure. It might be used for things like wading, swimming, ice skating, fishing, or snowmobiling. It could be In any case, boat is in |
These are all well-established tags.