Skip to content

deploy-preview: Update wording; Add map param to link#1478

Merged
tyrasd merged 1 commit intomainfrom
tordans-patch-2
Mar 11, 2025
Merged

deploy-preview: Update wording; Add map param to link#1478
tyrasd merged 1 commit intomainfrom
tordans-patch-2

Conversation

@tordans
Copy link
Copy Markdown
Collaborator

@tordans tordans commented Mar 9, 2025

Current version:

image

New version:

image
  • Add the map param so we don't start zoomed out but somewhere where it is more likely to find osm objects to test the changes
    eg https://pr-1348--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466
    This incorporates the review from deploy-preview: Change link to paris #1348 and superseeds that PR.
  • Add a hint to the test docs
    https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L38-L69
  • Add a hint to the id preview system
    http://preview.ideditor.com/

I think those changes will help to make reviewing quicker.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2025

🍱 You can preview the tagging presets of this pull request here.

@tyrasd tyrasd added documentation Improvements or additions to documentation ci labels Mar 11, 2025
@tyrasd tyrasd merged commit 8002f94 into main Mar 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants