Skip to content

Fix broken "Address" documentation link#1489

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
Vectorial1024:addr_docs
Mar 24, 2025
Merged

Fix broken "Address" documentation link#1489
tyrasd merged 3 commits intoopenstreetmap:mainfrom
Vectorial1024:addr_docs

Conversation

@Vectorial1024
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

See openstreetmap/iD#10905 , especially openstreetmap/iD#10905 (comment)

Related issues

None.

Links and data

N/A

@Vectorial1024
Copy link
Copy Markdown
Contributor Author

This should somehow fix openstreetmap/iD#10905

@Vectorial1024
Copy link
Copy Markdown
Contributor Author

@k-yle

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

k-yle
k-yle previously requested changes Mar 24, 2025
Comment thread data/fields/address.json Outdated
@Vectorial1024
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

Previewing this feature: https://pr-1489--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.86/14.65631/121.03323&disable_features=boundaries&background=Bing&id=n12494693314

image

Search

N/A

Info-i

The sidebar "Address" section exists. When clicking on the "i" button for more information, indeed, the relevant documentation is shown:

address-tag-documentation

Following the "view documentation" link brings me to this page: Key:addr:*

Thus, the PR is working as expected.

Wording

N/A

PR code review

Co-authored-by: Kyℓe Hensel <k-yle@users.noreply.github.com>
@Vectorial1024 Vectorial1024 requested a review from k-yle March 24, 2025 10:22
@Vectorial1024
Copy link
Copy Markdown
Contributor Author

@k-yle I have fixed the formatting problems found by Prettier. May you re-run the workflows?

@tyrasd tyrasd added the bug Something isn't working label Mar 24, 2025
@tyrasd tyrasd dismissed k-yle’s stale review March 24, 2025 12:23

addressed

@tyrasd tyrasd merged commit 6a6ca24 into openstreetmap:main Mar 24, 2025
5 checks passed
@Vectorial1024 Vectorial1024 deleted the addr_docs branch November 4, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants