Skip to content

[shop/esoteric] create preset for Esoteric Store#1505

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
piperswe:add-shop-esoteric
Nov 11, 2025
Merged

[shop/esoteric] create preset for Esoteric Store#1505
tyrasd merged 3 commits intoopenstreetmap:mainfrom
piperswe:add-shop-esoteric

Conversation

@piperswe
Copy link
Copy Markdown
Contributor

@piperswe piperswe commented Apr 2, 2025

Description, Motivation & Context

Esoteric shops are somewhat common, but not frequently tagged in OSM. shop=esoteric on a building=retail causes iD to treat a way as just a building, with no suggestions for shop=-related tags. Adding the shop=esoteric preset to the tagging schema may encourage mappers to tag them properly.

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Used on 183 entities: 173 nodes and 10 ways

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@matkoniecz
Copy link
Copy Markdown
Collaborator

@tyrasd Can you approve run of preview generator?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 4, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator

I vaguely remembered shop=new_age and it seemed to be a duplicate but wiki claims that it is a subset of this one.

shop=esoteric on a building=retail causes iD to treat a way as just a building, with no suggestions for shop=-related tags.

BTW, much better tagging is to not merge building object and shop object into one element ( https://wiki.openstreetmap.org/wiki/One_feature,_one_OSM_element )
It is not fatal but causes endless confusing issues

@matkoniecz
Copy link
Copy Markdown
Collaborator

Comment thread data/presets/shop/esoteric.json Outdated
@matkoniecz matkoniecz closed this Nov 8, 2025
@matkoniecz matkoniecz reopened this Nov 8, 2025
@matkoniecz

This comment has been minimized.

Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com>
@tyrasd tyrasd merged commit 1a0ad0d into openstreetmap:main Nov 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants