Skip to content

Add option container to buildingfield#1524

Merged
tyrasd merged 1 commit intomainfrom
tordans-patch-3
Sep 16, 2025
Merged

Add option container to buildingfield#1524
tyrasd merged 1 commit intomainfrom
tordans-patch-3

Conversation

@tordans
Copy link
Copy Markdown
Collaborator

@tordans tordans commented Apr 20, 2025

Description, Motivation & Context

https://wiki.openstreetmap.org/wiki/Tag:building%3Dcontainer is used quite often 12k and a good tag to map a container that is used as a permanent building. It does not describe the use of the building but the style, though, which makes it less ideal but in some cases it is better than building=yes.

This adds it to the building=* field as a named option.

The wiki data item looks OK as well https://wiki.openstreetmap.org/wiki/Item:Q5571

Related issues

-

Links and data

Relevant tag usage stats:

https://taginfo.openstreetmap.org/tags/building%3Dcontainer
https://taghistory.raifer.tech/#***/building/container

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@tordans tordans added the field label Apr 20, 2025
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@tordans
Copy link
Copy Markdown
Collaborator Author

tordans commented Apr 20, 2025

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1524--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.95/51.02700/12.82004&disable_features=boundaries&background=GEOSN-DOP-RGB

image

Icon: There is actually a icon for building=container in roentgen https://github.com/openstreetmap/iD/blob/develop/svg/roentgen/building_container.svg
However, I think that does not look enough like a house and this would be too much. Also this is not a preset, just a options translation.

Info-i

image

Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@tyrasd tyrasd merged commit cea8c7e into main Sep 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants