Add three presets for substation=minor_distribution (Kiosk, Building, Tower)#1543
Add three presets for substation=minor_distribution (Kiosk, Building, Tower)#1543tordans wants to merge 7 commits intoopenstreetmap:mainfrom
substation=minor_distribution (Kiosk, Building, Tower)#1543Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
This will hopefully make it, so that when I select a building=yes this gets overwritten with building=service.
This looked confusing in the editor, see testing notes
Test-Documentation
|
|
@flacombe could you have a look at this and check if this has any relevant issues? |
|
Hello @tordans Thank you for mentioning and refining those presets! I see no major problems:
The two points I want to raise are:
Furthermore, although it's advanced tagging so probably outside of the scope of these presets, cabinet tagging may be completed with transformers inside of them. All the best |
|
Thanks for checking this!
Thanks. I saw it on one example (that fits the image I have in mind for this one of the presets) but removed it now.
Given the quite complex tagging I think adding more presets would be a good idea. Maybe some should be scoped for certain countries… — But lets do that later/separately. And ideally by someone who knows more about this than me ;-). |
I got it clearer now, thank you.
I wonder if such node (https://www.openstreetmap.org/node/2880673331) would already be covered by this PR without any change? |
| "address", | ||
| "gnis/feature_id-US", | ||
| "transformer", | ||
| "phases" |
There was a problem hiding this comment.
Regarding buildings, they are mostly drawn as polygons, so transformer shouldn't be mixed with substations in a building (transformer would be added as a separate node inside).
That's directly related to those affinities.
So I would remove transformer, frequency and phases for such ones (and keep them for cabinet and poles substations, according to my last answer)
There was a problem hiding this comment.
@tordans what you think about this comment?
I plan to close that PR as abandoned in about 120 days.
(EDIT: also emailed on 3rd April 2026)
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
matkoniecz
left a comment
There was a problem hiding this comment.
(not saying that suggestion/request present there must be followed - but can you answer it?)
|
@tordans - have you seen those comments? |







Description, Motivation & Context
I am having a hard time mapping those minor distribution "buildings". This PR adds three presets that provide explicit tagging recommendation for common objects.
Relevant OSM Wiki links:
Examples:
Relevant tag usage stats:
None; Hard to analyse given the many sub tags.
In general all those tags are well documented and established.
https://taghistory.raifer.tech/#***/building/service&***/building/transformer_tower&***/substation/minor_distribution&***/man_made/street_cabinet&***/power/substation
Related issues
None
Translations
Some keywords we should add to the German translation:
substation_minor_distribution_building.jsonsubstation_minor_distribution_kiosk.jsonsubstation_minor_distribution_tower.jsonChecklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.