Skip to content

Add three presets for substation=minor_distribution (Kiosk, Building, Tower)#1543

Open
tordans wants to merge 7 commits intoopenstreetmap:mainfrom
tordans:substation
Open

Add three presets for substation=minor_distribution (Kiosk, Building, Tower)#1543
tordans wants to merge 7 commits intoopenstreetmap:mainfrom
tordans:substation

Conversation

@tordans
Copy link
Copy Markdown
Collaborator

@tordans tordans commented May 11, 2025

Description, Motivation & Context

I am having a hard time mapping those minor distribution "buildings". This PR adds three presets that provide explicit tagging recommendation for common objects.

Relevant OSM Wiki links:

Examples:

Relevant tag usage stats:

None; Hard to analyse given the many sub tags.

In general all those tags are well documented and established.
https://taghistory.raifer.tech/#***/building/service&***/building/transformer_tower&***/substation/minor_distribution&***/man_made/street_cabinet&***/power/substation

Related issues

None

Translations

Some keywords we should add to the German translation:

substation_minor_distribution_building.json

stromhäuschen, stromhaus, trafostation, Strom

    "tags": {        "building": "service",        "utility": "power"    },
    "addTags": {        "power": "substation",        "substation": "minor_distribution"    },
    "terms": [        "minor distribution station",        "small masonry building"    ],
    "name": "Substation (Building)"

substation_minor_distribution_kiosk.json

Trafo-Kompaktstation, Stromhäuschen, Stromhaus, Strom

    "tags": {        "man_made": "street_cabinet",        "substation": "minor_distribution"    },
    "addTags": {        "utility": "power",        "power": "substation"    },
    "terms": [        "kiosk",        "compact"    ],
    "name": "Substation (Kiosk)"

substation_minor_distribution_tower.json

Turm, Turmstation, Trafotrum, Transformatorenturm, Trafoturmstation, Trafo-Kompaktstation, Strom

    "tags": {        "building": "transformer_tower"    },
    "addTags": {        "utility": "power",        "power": "substation",        "substation": "minor_distribution"    },
    "terms": [        "transformer building",        "electricity pole"    ],
    "name": "Substation (Tower)"

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

tordans added 2 commits May 11, 2025 17:36
This will hopefully make it, so that when I select a building=yes this gets overwritten with building=service.
This looked confusing in the editor, see testing notes
@tordans
Copy link
Copy Markdown
Collaborator Author

tordans commented May 11, 2025

Test-Documentation substation_minor_distribution_building.json

Preview links & Sidebar Screenshots

Overpass: https://overpass-turbo.eu/s/23Ui

(Outdated; Fields changed a bit)
image

  • The "Type", "Type" Fields are not ideal. I remove the first Type which was power=substation from the fields to clean this up. I don't think that field needs to be present given that the preset is named Substation and the options don't show anything I would like to switch to.

  • I also remove the "Type" (substation) because it does not explain anything and no one would want to change that (or should)

  • FYI: When I select an existing building and change the preset, all fields get updated.

Search

image

Search terms work great.

Info-i

Picket the building data here to signify that this has to be an actual building, not the kiosk type.

image

Test-Documentation substation_minor_distribution_tower.json

Preview links & Sidebar Screenshots

Overpass: https://overpass-turbo.eu/s/23Uf

Example: https://pr-1543--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/51.05082/12.82381&disable_features=boundaries&background=Bing&id=w228749027

(Outdated; Fields changed a bit)
image

Search

./.

Info-i

image

Test-Documentation substation_minor_distribution_kiosk.json

Preview links & Sidebar Screenshots

Overpass: https://overpass-turbo.eu/s/23Ug

Example: https://pr-1543--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/51.04404/12.80905&disable_features=boundaries&background=Bing&id=n6544854454

(Outdated; Fields changed a bit)
image

  • I removed the "Type (man_made)", because it does not explain anything and no one would want to change that (or should)
  • I also remove the "Type" (substation) for the same reason

Search

./.

Info-i

image

@tordans
Copy link
Copy Markdown
Collaborator Author

tordans commented Aug 17, 2025

@flacombe could you have a look at this and check if this has any relevant issues?

@flacombe
Copy link
Copy Markdown
Contributor

flacombe commented Aug 17, 2025

Hello @tordans

Thank you for mentioning and refining those presets!

I see no major problems:

  • Tagging is fine
  • Willing to remove unnecessary static fields from the presets is relevant

The two points I want to raise are:

  • there is no need for frequency on those substations (edit: there is no need for building substation but can be kept on cabinet and poles). It's more a property for devices (transformers, compensators inside substations) than for facilities.
  • A fourth preset for substations on poles can be valuable in some countries (some countries consider a transformer on a pole is a minor distribution substation and some other don't)

Furthermore, although it's advanced tagging so probably outside of the scope of these presets, cabinet tagging may be completed with transformers inside of them.
Charts can be seen here: https://wiki.openstreetmap.org/wiki/Proposal:Substation_nodes_extension

All the best

Comment thread data/presets/power/substation_minor_distribution_building.json Outdated
Comment thread data/presets/power/substation_minor_distribution_kiosk.json Outdated
@tordans
Copy link
Copy Markdown
Collaborator Author

tordans commented Aug 17, 2025

Thanks for checking this!

there is no need for frequency on those substations. It's more a property for devices (transformers, compensators inside substations) than for facilities.

Thanks. I saw it on one example (that fits the image I have in mind for this one of the presets) but removed it now.

A fourth preset for substations on poles can be valuable in some countries (some countries consider a transformer on a pole is a minor distribution substation and some other don't)

Given the quite complex tagging I think adding more presets would be a good idea. Maybe some should be scoped for certain countries… — But lets do that later/separately. And ideally by someone who knows more about this than me ;-).

@tordans tordans requested a review from k-yle August 17, 2025 15:29
@flacombe
Copy link
Copy Markdown
Contributor

flacombe commented Aug 17, 2025

Thanks. I saw it on one example (that fits the image I have in mind for this one of the presets) but removed it now.

I got it clearer now, thank you.
That's because the substation is merged with the transformer inside on the same node, so the frequency is related to the transformer and could be preserved only for cabinets and poles substations only, sorry for having mistaken it.
At the end, iD could merge substation and transformer preset on such nodes.

Given the quite complex tagging I think adding more presets would be a good idea. Maybe some should be scoped for certain countries… — But lets do that later/separately. And ideally by someone who knows more about this than me ;-).

I wonder if such node (https://www.openstreetmap.org/node/2880673331) would already be covered by this PR without any change?
It's an actual substation on a power pole

"address",
"gnis/feature_id-US",
"transformer",
"phases"
Copy link
Copy Markdown
Contributor

@flacombe flacombe Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding buildings, they are mostly drawn as polygons, so transformer shouldn't be mixed with substations in a building (transformer would be added as a separate node inside).
That's directly related to those affinities.
So I would remove transformer, frequency and phases for such ones (and keep them for cabinet and poles substations, according to my last answer)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tordans what you think about this comment?

Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tordans what you think about this comment?

I plan to close that PR as abandoned in about 120 days.

(EDIT: also emailed on 3rd April 2026)

Comment thread data/presets/power/substation_minor_distribution_tower.json Outdated
Comment thread data/presets/power/substation_minor_distribution_kiosk.json Outdated
tordans and others added 2 commits October 18, 2025 13:20
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1543 (comment)

(not saying that suggestion/request present there must be followed - but can you answer it?)

@matkoniecz
Copy link
Copy Markdown
Collaborator

@tordans - have you seen those comments?

@matkoniecz matkoniecz added the waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-preset waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants