-
Notifications
You must be signed in to change notification settings - Fork 252
Add roof shape and roof height fields to building presets #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0d02970
Create height.json
trs998 4eff122
Create shape.json
trs998 2f27642
Update shape.json
trs998 731c69b
Update building.json
trs998 c13d537
Update building_part.json
trs998 7d42c3d
Update roof.json
trs998 ff166c7
Update data/fields/roof/height.json
trs998 b2186ad
Update data/fields/roof/shape.json
trs998 352ab55
Update height.json
trs998 fedf1ae
Update data/fields/roof/shape.json
tordans 7383b79
Update data/fields/roof/shape.json
tordans 0517e47
Update data/fields/roof/height.json
tordans 68e6c4e
Update data/fields/roof/height.json
tordans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "roof:height", | ||
| "minValue": 0, | ||
| "type": "number", | ||
| "label": "Roof Height (Meters)" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "key": "roof:shape", | ||
| "type": "combo", | ||
| "label": "Roof Shape", | ||
| "strings": { | ||
| "options": { | ||
| "flat": "Flat", | ||
| "gabled": "Gabled", | ||
| "skillion": "Skillion", | ||
| "hipped": "Hipped", | ||
| "half-hipped": "Half-Hipped", | ||
| "mansard": "Mansard", | ||
| "gambrel": "Gambrel", | ||
| "pyramidal": "Pyramidal", | ||
| "cone": "Cone", | ||
| "dome": "Dome", | ||
| "onion": "Onion", | ||
| "round": "Round" | ||
| } | ||
| }, | ||
| "autoSuggestions": true, | ||
| "customValues": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,8 @@ | |
| "not/name", | ||
| "operator", | ||
| "roof/colour", | ||
| "roof/shape", | ||
| "roof/height", | ||
| "smoking", | ||
| "wheelchair" | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be fancy about it, you could extract those three fields into a template to share them, see https://github.com/openstreetmap/id-tagging-schema/tree/main/data/presets/%40templates
That will make it easier to not forget one later…