Skip to content

Restore optional fields of Bakery preset#1554

Merged
tyrasd merged 2 commits intoopenstreetmap:mainfrom
novolife:bakery
Oct 14, 2025
Merged

Restore optional fields of Bakery preset#1554
tyrasd merged 2 commits intoopenstreetmap:mainfrom
novolife:bakery

Conversation

@novolife
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Add the following fields to bakery for easy filling:

Field Reason
internet_access Some shops have free wifi for customers
poi bakery is a kind of poi
air_conditioning AC is better for foods
branch_brand for bakery chains
brand for bakery chains

Related issues

Closes #1526

Links and data

Relevant OSM Wiki links:
Tag:shop=bakery

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

Preview link

Sidebar

Search

Search

Info-i

Info

Info

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@tordans tordans added add-field add existing field to more entries, for field creation see new-field waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on labels May 22, 2025
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented May 22, 2025

@tyrasd could you have a look at this please and at my question in ideditor/schema-builder#204
I wonder if we really want to add all kind of moreFields on the child-shop-presets or … if we should find a different way to inherit fields from the parent instead. Right now, the system is quite confusing IMO with some child presets having inherited fields and others not…

@tordans tordans requested a review from tyrasd May 22, 2025 20:45
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. I simplified this slightly to inherit all of the shops fields to make the list easier to maintain in the future.

@tyrasd tyrasd changed the title add fields for bakery Restore optional fields of Bakery preset Oct 14, 2025
@tyrasd tyrasd merged commit 1389b61 into openstreetmap:main Oct 14, 2025
5 checks passed
@novolife novolife deleted the bakery branch October 17, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add 'branch=*' field to shop=bakery

3 participants