add Weather Station preset by novolife · Pull Request #1558 · openstreetmap/id-tagging-schema

novolife · 2025-05-23T07:38:19Z

Description, Motivation & Context

man_made=monitoring_station + monitoring:weather=yes

Weather stations are very common in the world.

Related issues

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:monitoring:weather

Relevant tag usage stats:
11,051 (monitoring:weather + man_made)

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

After you submit your PR, the system will create a preview and comment on your PR:

🍱 You can preview the tagging presets of this pull request here.
If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

github-actions · 2025-05-23T12:09:33Z

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

tordans · 2025-05-23T12:47:51Z

For reference, those are the fields that are added indirectly:

https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/man_made/monitoring_station.json#L8-L15

I wonder: Should this have more of the "important tags" from https://wiki.openstreetmap.org/wiki/Key:monitoring:weather#Important_Tags?
It might be worth double checking the actual usage of those tag combinations.

Actually, I just played around with postpass to see if that is usable. The queries are not ideal, but it produces a few numbers…

Show numbers

curl -g http://postpass.geofabrik.de/api/0.2/interpreter --data-urlencode "data=
    SELECT 'name' AS tag, COUNT(*) AS station_count, NULL::geometry AS geom
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'name'
UNION ALL
    SELECT 'int_name', COUNT(*), NULL::geometry
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'int_name'
UNION ALL
    SELECT 'ref:wmo', COUNT(*), NULL::geometry
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'ref:wmo'
UNION ALL
    SELECT 'ref:wigos', COUNT(*), NULL::geometry
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'ref:wigos'
UNION ALL
    SELECT 'ref', COUNT(*), NULL::geometry
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'ref'
UNION ALL
    SELECT 'ref:icao', COUNT(*), NULL::geometry
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'ref:icao'
UNION ALL
    SELECT 'ele', COUNT(*), NULL::geometry
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'
    AND tags ? 'ele'"

{
    "type": "FeatureCollection",
    "features": [
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "ele",
                "station_count": 2116
            }
        },
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "ref:icao",
                "station_count": 110
            }
        },
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "ref:wigos",
                "station_count": 163
            }
        },
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "ref:wmo",
                "station_count": 825
            }
        },
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "int_name",
                "station_count": 293
            }
        },
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "ref",
                "station_count": 2675
            }
        },
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "name",
                "station_count": 5958
            }
        }
    ],
    "properties": {
        "generator": "Postpass API 0.2",
        "timestamp": "2025-05-23T12:20:32Z"
    }
}

% curl -g http://postpass.geofabrik.de/api/0.2/interpreter --data-urlencode "data=
    SELECT 'total' AS tag, COUNT(*) AS station_count, NULL::geometry AS geom
    FROM postpass_point
    WHERE tags->>'monitoring:weather' = 'yes'
    AND tags->>'man_made' = 'monitoring_station'"

{
    "type": "FeatureCollection",
    "features": [
        {
            "type": "Feature",
            "geometry": {
                "type": null
            },
            "properties": {
                "tag": "total",
                "station_count": 8887
            }
        }
    ],
    "properties": {
        "generator": "Postpass API 0.2",
        "timestamp": "2025-05-23T12:25:36Z"
    }
}

novolife · 2025-05-23T13:04:29Z

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1558--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466

Node

Area

Search

Info-`i`

Wording

American English
name, aliases (if present) use Title Case
terms (if present) use lower case, sorted A-Z

tordans · 2025-05-23T13:07:55Z

@novolife LGTM. Let me know if you want to release this as is or look at the additional fields mentioned in #1558 (comment) first. Both is fine with me.

novolife · 2025-05-23T13:18:18Z

#1558

I'm happy to add these fields, at least name and ele seem to be common information. But the question is, are these fields really as important as the wiki says? Honestly, I am not so familiar with weather.

novolife · 2025-05-23T14:21:19Z

tordans · 2025-05-23T14:44:00Z

@gmgeo it looks like you know a bit about weather stations because I think you edited the wiki page. Could you check this preview?

One thing I wonder is, if we should add those ref: values and if, should they be international? Reading the wiki they might be something only for the US? We could scope them for the US, if that is the case…

matkoniecz · 2025-11-03T16:01:54Z

close/reopen to get preview up

matkoniecz · 2026-02-25T15:33:55Z

@@ -0,0 +1,5 @@
+{
+    "key": "ref:wigos",
+    "type": "text",


is it deliberate it is type: text, not type: identifier?

see https://github.com/search?q=repo%3Aopenstreetmap%2Fid-tagging-schema%20identifier&type=code

see https://github.com/ideditor/schema-builder?tab=readme-ov-file#type

matkoniecz · 2026-02-25T15:36:13Z

@@ -0,0 +1,5 @@
+{
+    "key": "ref:wmo",


do we really need ref:wmo ?

after reading https://wiki.openstreetmap.org/wiki/Key:ref:wigos it seems to being replaced by ref:wigos and does not even have own key page at wiki

I am not expert on this topic and either way it would be nice if wiki would be less confusing about this

matkoniecz · 2026-02-25T15:39:29Z

+            "cosmic_ray": "Cosmic Ray",
+            "dissolved_oxygen": "Dissolved Oxygen",
+            "flow_rate": "Flow_rate",
+            "glonass": "GLONASS",


how monitoring glonass is a weather station thing?

(I may be wrong, and maybe it is entirely within range of what weather stations do)

matkoniecz · 2026-02-25T15:42:00Z

+            "pyranometer": "Pyranometer",
+            "pyrgeometer": "Pyrgeometer",
+            "pyrheliometer": "Pyrheliometer",
+            "radar": "Radar",


Suggested change

"radar": "Radar",

"radar": "Weather Radar",

?

matkoniecz · 2026-02-25T15:43:12Z

+            "forward_scatter_sensor": "Forward Scatter Sensor",
+            "grass_minimum_thermometer": "Grass Minimum Thermometer",
+            "humidity_sensor": "Humidity Sensor",
+            "hygrometer": "Hygrometer",


seems not listed at https://wiki.openstreetmap.org/wiki/Key:monitoring:weather

have you confirmed that all tags being added are documented at OSM Wiki and there are not controversial in some way?

matkoniecz · 2026-02-25T15:44:52Z

I am really overwhelmed by this PR. Personally I would prefer more and smaller PRs, that would be easier to review and merge.

(when there is one problematic thing it blocks entire PR, which happens more easily when adding entire pile of things)

matkoniecz · 2026-02-25T15:48:01Z

+    "moreFields": [
+        "ref/wmo",


Suggested change

"moreFields": [

"ref/wmo",

"moreFields": [

"{man_made/monitoring_station}",

"ref/wmo",

or is not inheriting ref deliberate?

https://github.com/novolife/id-tagging-schema/blob/3a4d53781380766081d2bfe8a1e4dfd5a3342626/data/presets/man_made/monitoring_station.json#L14

matkoniecz · 2026-02-25T15:49:10Z

If my proposed changes are dumb (which is possible): just explain why it makes no sense. But at least about type: identifier, I am fairly sure.

matkoniecz · 2026-03-13T17:26:26Z

@novolife Is this PR abandoned or do you plan on handling comments?

matkoniecz · 2026-04-02T07:41:17Z

ping @novolife

matkoniecz · 2026-04-11T06:09:12Z

closing as abandoned, see #2178

matkoniecz · 2026-04-11T06:20:36Z

Conversation

novolife commented May 23, 2025

Description, Motivation & Context

Related issues

Links and data

Checklist and Test-Documentation Template

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

tordans commented May 23, 2025

Uh oh!

novolife commented May 23, 2025

Test-Documentation

Preview links & Sidebar Screenshots

Node

Area

Search

Info-i

Wording

Uh oh!

tordans commented May 23, 2025

Uh oh!

novolife commented May 23, 2025

Uh oh!

novolife commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tordans commented May 23, 2025

Uh oh!

matkoniecz commented Nov 3, 2025

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz commented Feb 25, 2026

Uh oh!

matkoniecz Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

matkoniecz commented Feb 25, 2026

Uh oh!

matkoniecz commented Mar 13, 2026

Uh oh!

matkoniecz commented Apr 2, 2026

Uh oh!

matkoniecz commented Apr 11, 2026

Uh oh!

matkoniecz commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Info-`i`

novolife commented May 23, 2025 •

edited

Loading