Skip to content

add historic presets#1559

Closed
novolife wants to merge 14 commits intoopenstreetmap:mainfrom
novolife:railway_car
Closed

add historic presets#1559
novolife wants to merge 14 commits intoopenstreetmap:mainfrom
novolife:railway_car

Conversation

@novolife
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

There are many disused train carriages around the world that are used for display or have been converted, but they are not mapped or not mapped correctly, this preset helps to label them correctly.

Related issues

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag:historic%3Drailway_car

Relevant tag usage stats:

1,110

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1559--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466

ss6

ss7

ss2

Search

ss1

ss8

Info-i

ss3

ss4

ss5

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@novolife novolife marked this pull request as draft May 24, 2025 14:34
@novolife
Copy link
Copy Markdown
Contributor Author

Just find out that the combinations of historic=xxx are complicated, I need to modify my original plan and add more presets.

@novolife novolife changed the title add Historic Railway Car preset add historic presets May 24, 2025
@novolife novolife closed this May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant