Fix fields of historic=aircraft

[novolife]

Description, Motivation & Context

Some fields are illegal in the last PR for historic=aircraft, and this PR is aim to fix them and find a proper way to show aircraft:type.

Related issues

#1556 (comment)

Links and data

Relevant tag usage stats:

…

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

1. After you submit your PR, the system will create a preview and comment on your PR:

   🍱 You can preview the tagging presets of this pull request here.
   If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

2. Once the preview is ready, use it to test your changes.

3. Now copy the snippet below into a new comment and fill out the blanks.

4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[novolife]

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1566--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466

Search

Info-i

Wording

• American English
• name, aliases (if present) use Title Case
• terms (if present) use lower case, sorted A-Z

[novolife]

@tordans @kjonosm Please check if this PR could solve the problems.

[kjonosm]

Hi @novolife! First of all thank you for your quick response. I am still struggling to make sense of the type tag as I think the values are not chosen well. Should it not refer to only one specific type? I am not a native English speaker but in your example an F-16 fighter jet could from my understanding refer to type=jet, type=military, type=fixed_wing or any combination like type=jet;military;fixed_wing which seems odd to me and doesn't allow for consistent tagging.

[tordans]

I agree, we should only list the values from https://wiki.openstreetmap.org/wiki/Key:aircraft:type if any.
All those are used only few times, yet https://taginfo.openstreetmap.org/keys/aircraft%3Atype#values so even those not very established. But given the complexity of picking a good type value on the spot, providing the list from the wiki is an advantage IMO.

[novolife]

Should it not refer to only one specific type?

The wiki page says

multiple values separated by semi-colon value separator.

So I think this PR meet this standard and allow people fill in the types that are not in the list. Anyway, the field may have some design flaws, but there's not much I can do about it. I'm not really in a position to design these types of filling rules, this needs to be discussed.

[tordans]

multiple values separated by semi-colon value separator.

We could still decide to make this a single select, though.
The wiki tends to add those lines like "just add more then one value if you like", not considering the implications for data consumers. However, in this case, I don't see an issue going either way
Right now of the ~800 usages, only 8 use semicolons (using the searchfield for ";"):

[kjonosm]

Maybe just leave the type field out for now and see in which direction tagging evolves. Adding manufacturer and model information might be enough to specify tagging.

[tordans]

I merged it as is now, because it is an improvement. Will check back about the type field.