Skip to content

Add river preset to water category#1567

Merged
tordans merged 1 commit intoopenstreetmap:mainfrom
novolife:river
Jul 30, 2025
Merged

Add river preset to water category#1567
tordans merged 1 commit intoopenstreetmap:mainfrom
novolife:river

Conversation

@novolife
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Currently, there is no River Area within the water body category in the default preset shown for area, so this PR adds the River Area to the default water body preset category and sorts by the number of tags in the top five tags in taginfo.

Related issues

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag%3Awater%3Driver

Relevant tag usage stats:

474,429

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1567--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466

Before:

ss2

After:

ss1

Search

Info-i

ss3

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. But lets wait for a few days so others can give feedback.

@tordans tordans added the preset label May 25, 2025
@tordans tordans changed the title add river to default water category Add river to default water category May 25, 2025
@tordans tordans changed the title Add river to default water category Add river preset to water category May 25, 2025
@novolife novolife requested a review from tordans June 7, 2025 05:21
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good also to me

@matkoniecz
Copy link
Copy Markdown
Collaborator

@tordans @tyrasd would it be OK for me to use "waitfor-pr-merge" if PR looks mergable to me? Or should I stay away from it?

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jul 30, 2025

@matkoniecz adding a approved review and the tag sounds like a good idea.
I though the approve would be enough but https://github.com/openstreetmap/id-tagging-schema/pulls?q=is%3Apr+is%3Aopen+reviewed-by%3A%40matkoniecz does not who the one you approved today 🤷 .
Update: That URL are probably only reviews of users with write access…

@tordans tordans added category-related New or modified categories for presets. and removed preset labels Jul 30, 2025
@tordans tordans merged commit 2d53ca9 into openstreetmap:main Jul 30, 2025
5 checks passed
@novolife novolife deleted the river branch September 12, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category-related New or modified categories for presets.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants