Skip to content

Add preset for climbing=route_bottom #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tordans merged 12 commits into from
Jun 17, 2025
Merged

Add preset for climbing=route_bottom #1590

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
143a120
Add preset for `climbing=route_bottom`
zbycz Jan 30, 2024
dec88c2
remove field `ele` - non-compatible type
zbycz Jun 7, 2025
6995169
add `yds_class` as it is used in many examples
zbycz Jun 7, 2025
8b58aa2
change grades to combo
zbycz Jun 13, 2025
6c16c13
change Length (Meters)
zbycz Jun 15, 2025
02edb41
add terms
zbycz Jun 15, 2025
d83c730
prettier
zbycz Jun 15, 2025
65a7d0d
add prerequisite tag "climbing:sport=yes" for Bolts
zbycz Jun 15, 2025
9d22fb9
Sport climbing (bolted climbing)
zbycz Jun 15, 2025
6ac727d
move fields to `fields` property
zbycz Jun 15, 2025
95f3856
Apply suggestions from code review
tordans Jun 15, 2025
cd73afd
Update data/fields/climbing/grade/yds_class.json
tordans Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/fields/climbing/bolts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "climbing:bolts",
"type": "number",
"minValue": 0,
"label": "Number of Bolts"
Comment thread
zbycz marked this conversation as resolved.
Outdated
}
6 changes: 6 additions & 0 deletions data/fields/climbing/grade/french.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "climbing:grade:french",
"type": "text",
Copy link
Copy Markdown
Collaborator

@tordans tordans Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should try to improve the data validation aspects for those grade fields.
type:text is the most open field which provides no validation.
However, the values are well defined, eg. https://taginfo.openstreetmap.org/keys/climbing%3Agrade%3Afrench#values

What are our options?

  • We could make it an combo field with strings and either list all or rely on taginfo to fill the missing (see autosuggest)
  • If there where a good website that we can link to, we could make it an identifier field and use the pattern to validate the input via Regex. The website should be something like a generic page that handles the input as search param, maybe something that shows the value in different grades?

This applies to all 3 grade fields.

I think we should at least do the combo so users are guided to well structures data.

Copy link
Copy Markdown

@musoke musoke Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grades are very diverse. French grades might benefit from a combo, but other grades get more complicated.

Copy link
Copy Markdown
Contributor Author

@zbycz zbycz Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the values from the grading table on wiki, and made them into a combo field. I took only the basic ones (without slash), i think it is a good start for the users to select, and of course it allows users to enter their own value, if they prefer.

"label": "Grade (French)",
"placeholder": "5c"
}
6 changes: 6 additions & 0 deletions data/fields/climbing/grade/saxon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "climbing:grade:saxon",
"type": "text",
"label": "Grade (Saxon)",
"placeholder": "VIIa"
}
6 changes: 6 additions & 0 deletions data/fields/climbing/grade/uiaa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "climbing:grade:uiaa",
"type": "text",
"label": "Grade (UIAA)",
"placeholder": "6-"
}
6 changes: 6 additions & 0 deletions data/fields/climbing/grade/yds_class.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "climbing:grade:yds_class",
"type": "text",
"label": "Grade (YDS)",
"placeholder": "5.10a"
}
6 changes: 6 additions & 0 deletions data/fields/climbing/length.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"key": "climbing:length",
"type": "number",
"minValue": 0,
"label": "Length (m)"
Comment thread
zbycz marked this conversation as resolved.
Outdated
}
5 changes: 5 additions & 0 deletions data/fields/climbing/sport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"key": "climbing:sport",
"type": "check",
Comment thread
zbycz marked this conversation as resolved.
"label": "Sport climbing"
Copy link
Copy Markdown
Collaborator

@tordans tordans Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do users really understand that this is "with bolts" where the other is "bring your own"? Can we make this part of the label without making it wrong in some cases…?

Eg. https://de.wikipedia.org/wiki/Sportklettern says "bouldern" is also sport climbing?

Copy link
Copy Markdown

@musoke musoke Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users will understand. Bouldering occasionally gets lumped under sport climbing for political reasons related to "sport climbing" being an Olympic sport. There may be some linguistic differences too, but most Germans I know also make a distinction between the two.

Copy link
Copy Markdown
Contributor Author

@zbycz zbycz Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explored this topic little bit more, and usually the hypernym Rock climbing, consists of Sport climbing (with bolts+rope), Bouldering (shorter, without bolts), etc. The wikipedia states it clearly.

It seems the Olympics really added some confusion here.

To make it clearer, I added a bracket: Sport climbing (bolted climbing) – specifically because we don't have the bouldering option (yet), so begginers could try to fit it wrongly. What do you think?

}
5 changes: 5 additions & 0 deletions data/fields/climbing/trad.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"key": "climbing:trad",
"type": "check",
Comment thread
zbycz marked this conversation as resolved.
"label": "Traditional climbing"
}
33 changes: 33 additions & 0 deletions data/presets/climbing/route_bottom.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
{
"icon": "temaki-abseiling",
"geometry": [
"point",
"vertex"
],
"fields": [
"name"
],
"moreFields": [
"climbing/grade/uiaa",
"climbing/grade/french",
"climbing/grade/saxon",
"climbing/grade/yds_class",
"website",
"climbing/length",
"climbing/sport",
"climbing/trad",
"climbing/bolts",
"description"
],
Comment on lines +7 to +21
Copy link
Copy Markdown
Collaborator

@tordans tordans Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"fields": [
"name"
],
"moreFields": [
"climbing/grade/uiaa",
"climbing/grade/french",
"climbing/grade/saxon",
"climbing/grade/yds_class",
"website",
"climbing/length",
"climbing/sport",
"climbing/trad",
"climbing/bolts",
"description"
],
"fields": [
"name",
"climbing/sport",
"climbing/trad",
"climbing/bolts",
],
"moreFields": [
"climbing/grade/uiaa",
"climbing/grade/french",
"climbing/grade/saxon",
"climbing/grade/yds_class",
"website",
"climbing/length",
"description"
],

Does every route have a name? Having the name field that prominent will result in users adding it as a free form field. What is the recommended name for a route?

Is there some way to promote a source in this schema? Like "From the signs at the wall" or "From the book XY"?

I think some fields should be fields. Aren't sport and trad fields we always want to be filled? (With bolts being conditional, see above)

Copy link
Copy Markdown
Collaborator

@tordans tordans Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the name: Looking at a few examples https://overpass-turbo.eu/s/25II the data looks good ATM. That might change, however, once we promote it to less experienced users.

Copy link
Copy Markdown

@musoke musoke Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most routes have a name. Rarely there is a sign. More often books, online guides, word of mouth.

Copy link
Copy Markdown
Contributor Author

@zbycz zbycz Jun 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, usually routes have names - I have never heard about a route without name. But when is someone mapping in the field – they could probably see there is a bolted route, but the name is not usually written there. It is maintained by the local climbing organization, usually appears in printed guides, and sometimes there is a signboard nearby with the names, difficulties and a map (topo).

I added the suggested fields to fields property.

New route looks like this, which is probably fine - the info buttons shows the additional clarification:
image

"terms": [
"rock climbing route"
Comment thread
zbycz marked this conversation as resolved.
Outdated
],
"tags": {
"climbing": "route_bottom"
},
"addTags": {
"sport": "climbing",
"climbing": "route_bottom"
},
"name": "Climbing Route Start"
}
⚡