Skip to content

Add climbing features#1591

Closed
harahu wants to merge 5 commits intoopenstreetmap:mainfrom
harahu:climbing
Closed

Add climbing features#1591
harahu wants to merge 5 commits intoopenstreetmap:mainfrom
harahu:climbing

Conversation

@harahu
Copy link
Copy Markdown
Contributor

@harahu harahu commented Jun 8, 2025

Merge first: #1590

Description, Motivation & Context

Climbing is an activity that is often heavily reliant on maps and guides. Such material often exists in digital format, but the standard is, unfortunately, that information on climbing routes and areas are hidden behind paywalls. I want to contribute to making it more common that (geographic) information about climbing routes is shared in the open, and I think OSM is the obvious arena to do that.

The main barrier I currently see to sharing such information is that the beginner editor that newcomers to OSM reach for (iD) does not have any support for climbing related features. So I've decided I want to do something about that. I'll do that with this PR, as well as a subsequent PR to iD itself, if this PR goes though, where I'll improve rendering of climbing routes.

The climbing key today has ~26000 uses, so I think it deserves recognition in the editor.

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
https://taginfo.openstreetmap.org/keys/climbing#overview

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if we can keep the momentum of #1590 and this going, this time… :-). Here are some initial thoughts.

For the relation stuff – which I don't know a lot about – we should also look at #1538 to add some good validations and guidance to the UI (once that is merged…).

Comment thread data/presets/climbing/area.json Outdated
Comment thread data/presets/climbing/crag.json Outdated
Comment thread data/presets/climbing/route.json Outdated
Comment thread data/presets/climbing/route_bottom.json Outdated
Comment thread data/presets/climbing/route_top.json
@harahu harahu requested a review from tordans June 11, 2025 11:02
@harahu
Copy link
Copy Markdown
Contributor Author

harahu commented Jun 11, 2025

@tordans Thank you for the (very useful) review! I've now made this PR completely independent of #1590, so the order in which they are merged doesn't matter anymore.

If you're happy with this PR in it's current state feel free to merge it. Alternatively, I am considering splitting this PR into four different PRs (one per feature), such that we can discuss and merge them all individually.

@harahu
Copy link
Copy Markdown
Contributor Author

harahu commented Jun 13, 2025

@tordans: Closing this in favor of #1596, #1597 and #1598.

@harahu harahu closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants