-
Notifications
You must be signed in to change notification settings - Fork 252
Update CONTRIBUTING.md about wiki items and wiki links #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zbycz
wants to merge
2
commits into
openstreetmap:main
Choose a base branch
from
zbycz:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I never did this before. Lets double check first if this is actually needed for the lookup … or only for the Wiki-Relation part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harahu you added wiki data items for your last two PRs, did you add those SiteLinks described here? Or did it work with just the data item with the right values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the SiteLinks as described in the guide, but I don't know whether that was on the critical path to getting the description and picture to show up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it was crtitical to show the description, though i am not sure about the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment helped me understand it is really needed and I also had to set the sitelink for all other wiki items i created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the only unresolved issue? I can confirm that Special:SetSiteLink is a required step.
and it's the hardest step to figure out imo, because the UI is broken1
Footnotes
the link appears in the top right corner of the screen for a split second while the page loads (example). you have to be very quick to click it before it disappears ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to Special:SetSitelink should be in the Tools section, alongside the link to the permalink. Depending on your skin and appearance preferences, it might be tucked away in a menu somewhere. The flash is because of the gadget (installed by default) that puts the link in Tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be pedantic, iD queries the wiki for data items that are linked to these page titles. It doesn’t run a separate query for the article then the data item. MediaWiki (Wikibase) handles all that for the client.
But to answer the original question, yes, setting a sitelink is necessary. It’s a bit confusing because there’s also typically a documentation wiki pages (P31) property listing all the different translations, but that only matters once the sitelink to the English version is established.