Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ Icons from different sources (_icon sets_) can be used in the tagging schema. He
<img alt="Screenshot of a preset in iD with the information details open." src="https://github.com/openstreetmap/id-tagging-schema/assets/111561/13549318-cd7c-4dd1-9948-7a2d84662f04" width="400" />

iD and other tools provide users with a way to learn more about the main tag of a preset. It is important to provide good information in this information panel. Here are a few notes on how to do this:
- Does your tag have a OSM Wiki data item? Click the small pencil icon next to the text to open the data item on the OSM Wiki. Improve this wording if needed. If the data item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process).
- Does your tag have a OSM Wiki data item? Click the small pencil icon next to the text to open the data item on the OSM Wiki. Improve this wording if needed.
- If the data item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process).
- iD queries the `Tag:<key>=<value>` page or `Key:<key>` page and prefers the more specific variant. It then uses "wiki sitelinks" to get the data item from the page. These can be set [here](https://wiki.openstreetmap.org/wiki/Special:SetSiteLink//wiki), see the documentation in link above.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I never did this before. Lets double check first if this is actually needed for the lookup … or only for the Wiki-Relation part.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harahu you added wiki data items for your last two PRs, did you add those SiteLinks described here? Or did it work with just the data item with the right values?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the SiteLinks as described in the guide, but I don't know whether that was on the critical path to getting the description and picture to show up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it was crtitical to show the description, though i am not sure about the image.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment helped me understand it is really needed and I also had to set the sitelink for all other wiki items i created.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only unresolved issue? I can confirm that Special:SetSiteLink is a required step.

and it's the hardest step to figure out imo, because the UI is broken1

Footnotes

  1. the link appears in the top right corner of the screen for a split second while the page loads (example). you have to be very quick to click it before it disappears

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to Special:SetSitelink should be in the Tools section, alongside the link to the permalink. Depending on your skin and appearance preferences, it might be tucked away in a menu somewhere. The flash is because of the gadget (installed by default) that puts the link in Tools.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be pedantic, iD queries the wiki for data items that are linked to these page titles. It doesn’t run a separate query for the article then the data item. MediaWiki (Wikibase) handles all that for the client.

But to answer the original question, yes, setting a sitelink is necessary. It’s a bit confusing because there’s also typically a documentation wiki pages (P31) property listing all the different translations, but that only matters once the sitelink to the English version is established.

- See, for example: [building key](https://wiki.openstreetmap.org/wiki/Item:Q108) and [building=yes tag](https://wiki.openstreetmap.org/wiki/Item:Q6135)
- Does your tag have a Wiki page with a good image?
- Your preset might need [a `reference` property](https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference) to force the system to use a specific tag for the information section.

Expand Down