Update roof shape field to add missing wiki suggestions#1654
Update roof shape field to add missing wiki suggestions#1654tyrasd merged 1 commit intoopenstreetmap:mainfrom
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
Checked in the editor, everything shows up as expected! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pinging @tordans as he merged some mergeable PRs I found.
I got confused a bit that you cannot type in roof shape field to filter possible entries but it is not really within responsibility of this PR.
|
@matkoniecz Pretty sure all that is needed to change that behaviour is change I also don't think |
tyrasd
left a comment
There was a problem hiding this comment.
confirmed that the additional options are documented and recently often used
Description, Motivation & Context
The OSM wiki has more suggested
roof_shapeoptions than are listed, all with excellent icons by @mxdanger. This PR adds all the roof shapes with icons to the schema in preperation for #1589Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.