remove dummy presets for secondary uses of the "emergency" tag#1680
Merged
remove dummy presets for secondary uses of the "emergency" tag#1680
Conversation
tyrasd
added a commit
to openstreetmap/iD
that referenced
this pull request
Aug 20, 2025
…eptions instead of relying on the presence of dummy presets in the tagging schema see also openstreetmap/id-tagging-schema#1680
tyrasd
added
the
waitfor-other
Collaborator
|
Is there anything blocking merge of openstreetmap/iD#11327 in iD? |
tyrasd
removed
the
waitfor-other
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
emergencytag is used both as a primary tag (e.g.emergency=ambulance_station) as well as a key of the access tagging schema. The "primary" emergency features only ever come as points or areas, while the "access" emergency tags are typically found on linear features.In order to avoid false-positives in the geometry-check validation of iD, the id-tagging-schema has a couple of dummy presets that allow the use of the tag on lines (see openstreetmap/iD@423329c). That workaround feels a bit hacky, and might be better handled as an exception directly in iD.
This PR would remove the dummy presets and could be merged once iD directly handles the
emergencytag exception.