Fix missing tag for memorial=blue_plaque preset#1689
Merged
tordans merged 1 commit intoopenstreetmap:mainfrom Sep 9, 2025
Merged
Fix missing tag for memorial=blue_plaque preset#1689tordans merged 1 commit intoopenstreetmap:mainfrom
memorial=blue_plaque preset#1689tordans merged 1 commit intoopenstreetmap:mainfrom
Conversation
Currently adding a blue plaque in iD results in a node with only `historic=memorial` - this fixes it to correctly add `memorial=blue_plaque` also.
Collaborator
|
Ah, yes, it looks like I/we fell into the naming trap that makes we think that tags will also be added. Follow up to #1601 |
tordans
approved these changes
Aug 26, 2025
tordans
added
bug
Collaborator
|
@tordans any idea why preview has not appeared here? (it is still unmerged so I wanted to test it to push it over finish line, especially if it is a bugfix) |
Collaborator
|
No idea why the preview is not there. I will merge it as is. I am very sure this is the right fix. |
tordans
changed the title
memorial=blue_plaque preset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Motivation & Context
Currently, adding a blue plaque in iD results in a node with only
historic=memorial- this fixes it to correctly addmemorial=blue_plaquealso.Links and data