Skip to content

Add wheelchair field to shop=health_food preset#1702

Merged
tyrasd merged 2 commits intoopenstreetmap:mainfrom
srujanaelicherla:add-wheelchair-health-food
Nov 25, 2025
Merged

Add wheelchair field to shop=health_food preset#1702
tyrasd merged 2 commits intoopenstreetmap:mainfrom
srujanaelicherla:add-wheelchair-health-food

Conversation

@srujanaelicherla
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

This PR adds the wheelchair field to the shop=health_food preset.
It ensures consistency with other shop presets (e.g., shop=bakery) and allows contributors to easily record accessibility information for health food shops.

Related issues
Closes #1262

Links and data

Relevant OSM Wiki links:
Key:wheelchair
Tag:shop=health_food

Relevant tag usage stats:
shop=health_food
wheelchair

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@srujanaelicherla
Copy link
Copy Markdown
Contributor Author

Test documentation

  • I have tested my changes in the preview.

Test workflow

  1. Opened the preview link and selected an existing "Health Food Shop".
  2. Scrolled down through the fields in the editor panel.

Expected result

The "Wheelchair Access" field should be visible in the preset.

Actual result

The "Wheelchair Access" field is present and works as expected.

Screenshot:
image

image

@srujanaelicherla srujanaelicherla force-pushed the add-wheelchair-health-food branch 2 times, most recently from c36abc5 to a2aeb6f Compare September 5, 2025 12:14
Comment thread data/fields/craft.json Outdated
@matkoniecz
Copy link
Copy Markdown
Collaborator

It ensures consistency with other shop presets (e.g., shop=bakery)

is it actually done for shop=bakery already?

@srujanaelicherla srujanaelicherla force-pushed the add-wheelchair-health-food branch from cc8e63d to 8271484 Compare September 8, 2025 11:03
@srujanaelicherla
Copy link
Copy Markdown
Contributor Author

Hi @matkoniecz Thanks for checking! I confirmed that shop.json (the parent for shop presets) does not currently include the general wheelchair field—only toilets/wheelchair. That means shop=bakery doesn’t have it either.

So this PR is filling the gap for shop=health_food, and it could make sense to extend wheelchair to other shop presets like bakery in a follow-up.

Comment thread data/presets/shop/health_food.json Outdated
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the fix to inherit all of the shop preset's optional fields. This was a bug we introduced accidentally in #987. Note to self: There are a handful of similar presets which have the same issue (e.g. shop=farm, etc.) from that PR.

@tyrasd tyrasd merged commit c68b9e7 into openstreetmap:main Nov 25, 2025
5 checks passed
@tyrasd tyrasd added the bug Something isn't working label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add wheelchair to shop=health_food

3 participants