Skip to content

Fix icon for Framing Shop preset#1707

Merged
tordans merged 1 commit intoopenstreetmap:mainfrom
arch0345:patch-3
Sep 8, 2025
Merged

Fix icon for Framing Shop preset#1707
tordans merged 1 commit intoopenstreetmap:mainfrom
arch0345:patch-3

Conversation

@arch0345
Copy link
Copy Markdown
Contributor

@arch0345 arch0345 commented Sep 8, 2025

Description, Motivation & Context

A hyphen was mistakenly used instead of an underscore in a0a49cc

Related issues

Closes openstreetmap/iD#11391

Links and data

https://rapideditor.github.io/temaki/docs/#icon-temaki-portrait_framed

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 8, 2025

Change looks good. If someone can confirm it works I will merge.

@arch0345
Copy link
Copy Markdown
Contributor Author

arch0345 commented Sep 8, 2025

Before:
image
After:
image

@tordans tordans changed the title Fix typo in icon name for Framing Shop preset Fix icon for Framing Shop preset Sep 8, 2025
@tordans tordans added the new-label changes the name, aliases or terms of a preset label Sep 8, 2025
@tordans tordans merged commit a593bbc into openstreetmap:main Sep 8, 2025
5 checks passed
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 8, 2025

Thanks!

@arch0345 arch0345 deleted the patch-3 branch September 8, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-label changes the name, aliases or terms of a preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bilderrahmengeschäft hat kein Icon

2 participants