Add fields to attraction preset#1713
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
7a6d9c1 to
59a10da
Compare
Test-DocumentationPreview links & Sidebar ScreenshotsLink to test object: https://pr-1713--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/43.67008/-79.39373&disable_features=boundaries&background=Bing&id=n4462028723 Tested by selecting an existing "Tourist Attraction" on the map. The new fields for Fee, Hours (
SearchSearched for "Tourist Attraction" and the preset was found correctly. Info-
|
are these also typically needed for things tagged only with |
|
Hi @matkoniecz, thank you for the review and for the thoughtful question! That's a great point. I believe these fields are valuable even for objects tagged only with the generic tourism=attraction for a couple of key reasons:
Hope this clarifies the reasoning! |
|
note: your comments sound and read like directly copied from chatgpt |
|
Hi @matkoniecz , that is a fair point. I was focused on making the justification sound professional and I guess I polished the wording a little too much. However, despite the wording, the core points are my own. I'll make sure to keep it more conversational from now on. Anyway, putting the style aside, does the reasoning sound good to you? |
viewpoints, monuments, nearly all local landmarks and nearly all natural curiosities have better tagging why you think for example viewpoints should be tagged as |
|
Hi @matkoniecz, You're right, thanks for the correction. It was a mistake for me to use "viewpoints" as an example as they should always be tagged with their more specific tags. My goal was about two other cases. Improving the 400k+ attractions already on the map and mapping the quirky stuff that doesn't fit another category. Sorry for the confusion caused. |
not 400k as vast majority is properly tagged, not only with |
|
Hi @matkoniecz, |
tyrasd
left a comment
There was a problem hiding this comment.
I'd recommend to avoid using tourism=attraction as the only primary tag of a feature in favor of tagging it as the feature type the attraction actually is (e.g. a monument, museum, church, etc.), which then automatically has the correct applicable fields and moreFields. That said, adding those fields as optional moreFields still does not hurt and should be fine to include.



Description, Motivation & Context
This PR adds the fee, level, and opening_hours fields to the tourism=attraction preset.
These are common and useful tags for tourist attractions. Adding them to the preset makes it easier for mappers to add this valuable information using the iD editor, improving the quality and completeness of map data.
Related issues
Closes #1634
Links and data
Relevant OSM Wiki links:
tourism=attraction: https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dattraction
fee: https://wiki.openstreetmap.org/wiki/Key:fee
level: https://wiki.openstreetmap.org/wiki/Key:level
opening_hours: https://wiki.openstreetmap.org/wiki/Key:opening_hours