Create olive_grove.json preset for landuse

[dp7x]

Description, Motivation & Context

fixes #1651

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[matkoniecz]

@tordans Can you approve also rerun?

[dp7x]

[dp7x]

Everything works properly in the preview, now I am looking at how to write a more precise information text for the preset:

[tordans]

Some notes for the review

• review the wiki documentation on this, when we last talked, there was none
• compare the fields/moreFields to other similar presets
• compare the fields/moreFields to common usage

[dp7x]

Hi @tordans , thanks.
I created the wiki data item, I hope this is ok: https://wiki.openstreetmap.org/wiki/Item:Q23173
About the fields, I started from "landuse=orchard" ; I will add more when they come to my mind.

[Oivo35]

@dp7x
Data item for the olive orchard already exists.
https://wiki.openstreetmap.org/wiki/Item:Q19753
And also wiki page.
https://wiki.openstreetmap.org/wiki/Tag:trees%3Dolive_trees

[dp7x]

Dear @Oivo35 , I know that the tag "trees=olive_trees" already exists, I have used it many times !
In fact my proposal is a new preset that combines in a unique object both tags "landuse=orchard" and "trees=olive_trees" to get the "olive grove" (commonly not called an orchard, even though technically it is).

[Oivo35]

@dp7x Why do you want to create new landuse=olive_grove tag if the definition of trees=olive_trees is "Specifies that an orchard is an olive tree orchard, grove or plantation."?
You can use for olive grove combination landuse=orchard + trees=olive_trees + produce=olive_oil.
This issue with landuse=olive_grove seems like #1667 - landuse=paddy tag for rice paddies.

[dp7x]

Because I think it would be useful for more accurate and informed mapping.
Otherwise, your reasoning would also apply, for example, to other presets like "meadow=meadow_orchard" or "orchard=meadow_orchard."
Likewise, it wouldn't have been necessary to create "landuse=vineyard": we could have used "landuse=orchard" + "crop=grape."
I think a preset should simplify the mapping process by helping users find exactly what they're looking for, while maintaining accuracy.

[Oivo35]

meadow=meadow_orchard or orchard=meadow_orchard are subtags. There is no landuse=meadow_orchard tag. Moreover, it is a type of orchard and doesn't describe output of orchard.
If the approach were to create tags for each type of output of orchard, then the trees or crop tags would be unnecessary.
So I doubt there is a need to create new top level tags like landuse=olive_grove, landuse=almond_grove, landuse=avocado_grove, landuse=bamboo_grove, landuse=hazel_grove, landuse=palm_grove etc.
trees=olive_trres is approved tag with clear definition.
landuse=vineyard tag was introduced in 2009. So before crop and produce tags.
Maybe you should open a discussion on the community forum about a new tag only for olive groves.

[matkoniecz]

why https://wiki.openstreetmap.org/wiki/Item:Q23173 is for landuse=olive_grove while #1717 (comment) shows subtag for landuse=orchard ?

[matkoniecz]

and yes, if you want to introduce new landuse value, redefine existing one and break data consumers it should have clear support from community to accept this (and even then you have long irritating period, see highway=busway)

[dp7x]

Hello @matkoniecz , there is a misunderstanding: I don't want to introduce a new landuse value.
Now I see my error: I tried to create the wiki data page but I did a big mistake in the tag value: sorry, i am new to this, I will try to correct.

So, at last, what I would like to obtain is exactly what you can see in the pull request preview and I showed in the picture of my previous message. I think it would be very useful for more than a reason and I see no problems with it, but if it can't be done please tell me and I will stop asking. Thanks for your support and understanding.

[matkoniecz]

at least to me general idea of this PR makes sense

Someone still needs to review it before merge (look at code and how it works) - I will try to do an independent review, but I have no right to merge PRs in this repo

[dp7x]

Thanks for your support @matkoniecz .
Could you also give me some hint on how to correctly create a better description for the preset, to replace the one showed in my previous comment ?

[matkoniecz]

is https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i helpful?

[dp7x]

is https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i helpful?

Sorry @matkoniecz, but no... it's trying to follow that link that I made the previous mess creating the new landuse value. I suppose that I should have to create a new item that combines both the tags I need, so that I can create a new short description for the preset, but I can't find a way on how to do it !

[matkoniecz]

from reading docs: using reference may work here, probably pointing at https://wiki.openstreetmap.org/wiki/Tag:trees%3Dolive_trees and its https://wiki.openstreetmap.org/wiki/Item:Q19753

would

Specifies that an orchard is an olive tree orchard, grove or plantation

description and https://wiki.openstreetmap.org/wiki/File:Olivares_de_la_campi%C3%B1a_estepe%C3%B1a.jpg image work well?

[dp7x]

would

Specifies that an orchard is an olive tree orchard, grove or plantation

description and https://wiki.openstreetmap.org/wiki/File:Olivares_de_la_campi%C3%B1a_estepe%C3%B1a.jpg image work well?

Yes, both description and linked image would be good in my opinion!
Thanks

[matkoniecz]

Can you then add reference ( https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference ) property?

See say

id-tagging-schema/data/fields/tee.json

Line 5 in d87f48d

"reference": {

[dp7x]

Can you then add reference ( https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference ) property?

See say

id-tagging-schema/data/fields/tee.json

Line 5 in d87f48d

"reference": {

Ok, I committed the changes, please take a look when you can.
Thanks

[dp7x]

Hi @matkoniecz and @tordans , could you please review ?
Thanks

[matkoniecz]

I am trying to help with PRs/issues in this repo

Sadly there is quite large backlog and there is limit how much I can review as a hobby/volunteering :(