Skip to content

add access and fee field to observation tower#1726

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
paulklie:observation_tower_access
Oct 21, 2025
Merged

add access and fee field to observation tower#1726
tyrasd merged 3 commits intoopenstreetmap:mainfrom
paulklie:observation_tower_access

Conversation

@paulklie
Copy link
Copy Markdown
Contributor

Links and data

Relevant OSM Wiki links:
observation tower

Relevant tag usage stats:
access: 1 751 (6.50%)
fee: 752 (2.8%)

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@paulklie
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

image Example: https://www.openstreetmap.org/node/2272382455 ### Wording
  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@paulklie paulklie changed the title added access and fee field to observation tower add access and fee field to observation tower Sep 16, 2025
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator

I wonder about putting them not only in moreFields but even exposing them by default.

@paulklie
Copy link
Copy Markdown
Contributor Author

paulklie commented Sep 17, 2025

I wonder about putting them not only in moreFields but even exposing them by default.

Was my original plan to, however the "fields" are inherited from man_made=tower, so modifying it would overwrite the default fields. Is it acceptable to duplicate the fields in the inherited preset?

@matkoniecz
Copy link
Copy Markdown
Collaborator

Ideally there would be better way to do this...

Would

    "fields": [
        "{man_made/tower}",
        "access_simple",
        "fee"
]

work by any chance?

(from looking at https://github.com/ideditor/schema-builder and not from testing!)

@paulklie
Copy link
Copy Markdown
Contributor Author

Ideally there would be better way to do this...

Would

    "fields": [
        "{man_made/tower}",
        "access_simple",
        "fee"
]

work by any chance?

(from looking at https://github.com/ideditor/schema-builder and not from testing!)

Good find, implemented and it works!

@matkoniecz
Copy link
Copy Markdown
Collaborator

nitpick: can you put fields before moreFields like in other files?

@paulklie
Copy link
Copy Markdown
Contributor Author

nitpick: can you put fields before moreFields like in other files?

good idea, done!

@tyrasd tyrasd added the add-field add existing field to more entries, for field creation see new-field label Oct 21, 2025
@tyrasd tyrasd merged commit 5ffa70a into openstreetmap:main Oct 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants