add access and fee field to observation tower#1726
add access and fee field to observation tower#1726tyrasd merged 3 commits intoopenstreetmap:mainfrom
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
I wonder about putting them not only in moreFields but even exposing them by default. |
Was my original plan to, however the "fields" are inherited from man_made=tower, so modifying it would overwrite the default fields. Is it acceptable to duplicate the fields in the inherited preset? |
|
Ideally there would be better way to do this... Would work by any chance? (from looking at https://github.com/ideditor/schema-builder and not from testing!) |
Good find, implemented and it works! |
|
nitpick: can you put fields before moreFields like in other files? |
good idea, done! |

Links and data
Relevant OSM Wiki links:
observation tower
Relevant tag usage stats:
access: 1 751 (6.50%)
fee: 752 (2.8%)
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.