make building=train_station searchable#1737
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
building=train_station.json searchablebuilding=train_station searchable
|
It looks good! Personally I would prefer if this preset didn't have a name field. Usually there is a separate node with the name of the train station. |
tyrasd
left a comment
There was a problem hiding this comment.
This was originally created as an unsearchable preset in openstreetmap/iD#2116 (comment) because the name was clashing with the main railway=station preset. But after openstreetmap/iD#5903, the name clash has been fixed and it should now be clear enough hopefully.




Description, Motivation & Context
Train Station Building is unsearchable due to the name could be chaotic, but we have many same building presets naming in same format and that means this could be searchable too.
Related issues
Closes #59
openstreetmap/iD#7480
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.