Skip to content

make building=train_station searchable#1737

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
novolife:patch-1
Nov 18, 2025
Merged

make building=train_station searchable#1737
tyrasd merged 3 commits intoopenstreetmap:mainfrom
novolife:patch-1

Conversation

@novolife
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

openstreetmap/iD#7480
This is intentional so mappers don't confuse this preset with the Train Station preset.
#59
Since the naming is more precise now, I think we could make the train station building preset searchable.

Train Station Building is unsearchable due to the name could be chaotic, but we have many same building presets naming in same format and that means this could be searchable too.

Related issues

Closes #59
openstreetmap/iD#7480

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

56,801

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1737--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.40/52.37694/9.74164&disable_features=boundaries&background=Bing&id=w265614707

ss

Search

ss1 2 ss2

Info-i

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@novolife novolife changed the title make building=train_station.json searchable make building=train_station searchable Sep 22, 2025
@Dimitar5555
Copy link
Copy Markdown
Contributor

It looks good!

Personally I would prefer if this preset didn't have a name field. Usually there is a separate node with the name of the train station.

@matkoniecz matkoniecz closed this Nov 18, 2025
@matkoniecz matkoniecz reopened this Nov 18, 2025
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally created as an unsearchable preset in openstreetmap/iD#2116 (comment) because the name was clashing with the main railway=station preset. But after openstreetmap/iD#5903, the name clash has been fixed and it should now be clear enough hopefully.

@tyrasd tyrasd merged commit ea8993e into openstreetmap:main Nov 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify train-station preset, potential add railway-station buiding preset

4 participants