Add presets from Proposal:Power circuits routing#1744
Add presets from Proposal:Power circuits routing#1744nlehuby wants to merge 3 commits intoopenstreetmap:mainfrom
Conversation
* power=circuit * power=line_section * topology field * deprecated power=branch & route=power
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPower circuit preset & topology field
tested with existing power circuit in Marocco: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.45/32.04117/-8.76985&id=r16330345 Section of power line
tested with existing line_section in Canada: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.00/46.20096/-70.72009&id=r19522468 search
power=route deprecation
from existing power=route in Germany: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.00/48.20525/11.82423 power=branch deprecation
from existing power=branch in the UK: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.55/51.71182/-4.70243&id=r18251489 |
|
Related to #1741 |
PR review Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Thanks for the review. What changes do you want to see in the Power route preset ? I've flagged it as outdated, see the images in the test-Documentation : |
| }, | ||
| { | ||
| "old": {"power": "branch"}, | ||
| "replace": {"power": "circuit"} |
There was a problem hiding this comment.
can it be always replaced this way?
if yes, why not do this as a bot edit rather than going through iD? Also, with 241 uses upgrading existing tagging (if that is useful and worth doing) will take comparable effort to doing PR review of that change https://taginfo.openstreetmap.org/tags/power=branch
There was a problem hiding this comment.
the same for other deprecation
note that these comments are not enabling bypassing https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct
if you do automated edit you must follow these rules
There was a problem hiding this comment.
In case of no further activity on this PR it will be closed
There was a problem hiding this comment.
According to the proposal page:
power=branchis to replace by power=circuit and case by case requiredpower=line_sectionrelationstype=route+route=poweris to replace bytype=power+power=circuit
For my part, I don't plan on making any large-scale, automatic changes. I think it’s up to the local communities interested in this topic to take on this issue, and some have already started doing so on their own perimeter. In particular, regarding the power=branch case, they seem to have been introduced mainly as part of an import project I know nothing about, so I certainly won’t be changing anything.
I simply suggest using the existing feature in the iD editor to notify contributors who might edit the object that this is no longer the correct way to label it, and to prevent new contributors from creating new objects with these tags. From what I understand, this is exactly what the feature in iD is meant to do, but if you don't think it's reasonable, I'll remove it.
There was a problem hiding this comment.
but if you don't think it's reasonable, I'll remove it.
please, do it
in my view this is effectively doing "large-scale, automatic changes" as at least some users press "update tags" blindly
and if these tags can be mass-transformed then it should be done with bot edit, not some manual distributed one
As disclaimer: yes, in past this deprecation feature was used and intended to be used differently, and I am effectively trying to change it
There was a problem hiding this comment.
So sorry for any confusion here - and yes, situation partially changed over say last year.
(@matkoniecz PR review)
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
please change file name (so also field code) to something like power_line_topology
you can have also other topologies and it will be more clear where context is not obvious
There was a problem hiding this comment.
Isn't that a bit early? The only documented use so far is for power circuits (YAGNI principle)
| "key": "power", | ||
| "value": "line_section" | ||
| }, | ||
| "name": "Section of Power Line" |
There was a problem hiding this comment.
I am quite confused by this, also after reading docs
matkoniecz
left a comment
There was a problem hiding this comment.
documentation of tags supported in iD should be understandable, current one refers to "tap point" without clarification what it is.
And what "tap point" seems to be obscure knowledge without obvious answers.










This PR adds the modifications approved in the Power circuits proposal: