Skip to content

Add presets from Proposal:Power circuits routing#1744

Open
nlehuby wants to merge 3 commits intoopenstreetmap:mainfrom
Jungle-Bus:power_circuit
Open

Add presets from Proposal:Power circuits routing#1744
nlehuby wants to merge 3 commits intoopenstreetmap:mainfrom
Jungle-Bus:power_circuit

Conversation

@nlehuby
Copy link
Copy Markdown
Contributor

@nlehuby nlehuby commented Sep 26, 2025

This PR adds the modifications approved in the Power circuits proposal:

* power=circuit
* power=line_section
* topology field
* deprecated power=branch & route=power
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@nlehuby
Copy link
Copy Markdown
Contributor Author

nlehuby commented Sep 26, 2025

Test-Documentation

Power circuit preset & topology field

Capture d’écran du 2025-09-26 09-24-35

in the relation section:
Capture d’écran du 2025-09-26 09-23-36

with documentation:
Capture d’écran du 2025-09-26 09-25-48

tested with existing power circuit in Marocco: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.45/32.04117/-8.76985&id=r16330345

Section of power line

Capture d’écran du 2025-09-26 09-27-54

in the relation section:
Capture d’écran du 2025-09-26 09-27-37

tested with existing line_section in Canada: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.00/46.20096/-70.72009&id=r19522468

search

Capture d’écran du 2025-09-26 09-25-03

power=route deprecation

Capture d’écran du 2025-09-26 09-33-48 Capture d’écran du 2025-09-26 09-32-50

from existing power=route in Germany: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.00/48.20525/11.82423

power=branch deprecation

Capture d’écran du 2025-09-26 09-35-36

from existing power=branch in the UK: https://pr-1744--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.55/51.71182/-4.70243&id=r18251489

@wolfy1339
Copy link
Copy Markdown

Related to #1741

Comment thread data/fields/topology.json Outdated
@wolfy1339
Copy link
Copy Markdown

PR review

Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@nlehuby
Copy link
Copy Markdown
Contributor Author

nlehuby commented Oct 31, 2025

Changes will be needed to https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/type/route/power.json

Thanks for the review.

What changes do you want to see in the Power route preset ? I've flagged it as outdated, see the images in the test-Documentation :
power route deprecated

Comment thread data/deprecated.json Outdated
},
{
"old": {"power": "branch"},
"replace": {"power": "circuit"}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be always replaced this way?

if yes, why not do this as a bot edit rather than going through iD? Also, with 241 uses upgrading existing tagging (if that is useful and worth doing) will take comparable effort to doing PR review of that change https://taginfo.openstreetmap.org/tags/power=branch

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same for other deprecation

note that these comments are not enabling bypassing https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct

if you do automated edit you must follow these rules

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of no further activity on this PR it will be closed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the proposal page:

  • power=branch is to replace by power=circuit and case by case required power=line_section relations
  • type=route + route=power is to replace by type=power + power=circuit

For my part, I don't plan on making any large-scale, automatic changes. I think it’s up to the local communities interested in this topic to take on this issue, and some have already started doing so on their own perimeter. In particular, regarding the power=branch case, they seem to have been introduced mainly as part of an import project I know nothing about, so I certainly won’t be changing anything.

I simply suggest using the existing feature in the iD editor to notify contributors who might edit the object that this is no longer the correct way to label it, and to prevent new contributors from creating new objects with these tags. From what I understand, this is exactly what the feature in iD is meant to do, but if you don't think it's reasonable, I'll remove it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if you don't think it's reasonable, I'll remove it.

please, do it

in my view this is effectively doing "large-scale, automatic changes" as at least some users press "update tags" blindly

and if these tags can be mass-transformed then it should be done with bot edit, not some manual distributed one

As disclaimer: yes, in past this deprecation feature was used and intended to be used differently, and I am effectively trying to change it

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for any confusion here - and yes, situation partially changed over say last year.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it's done.

@matkoniecz matkoniecz added waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. new-preset deprecating labels Mar 8, 2026
Comment thread data/fields/topology.json
@@ -0,0 +1,11 @@
{
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change file name (so also field code) to something like power_line_topology

you can have also other topologies and it will be more clear where context is not obvious

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that a bit early? The only documented use so far is for power circuits (YAGNI principle)

"key": "power",
"value": "line_section"
},
"name": "Section of Power Line"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matkoniecz matkoniecz added waitfor-documentation documentation about this tag is missing in the OSM wiki and removed waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. deprecating labels Apr 11, 2026
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation of tags supported in iD should be understandable, current one refers to "tap point" without clarification what it is.

And what "tap point" seems to be obscure knowledge without obvious answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-preset waitfor-documentation documentation about this tag is missing in the OSM wiki

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants