improve definition of template presets be be less confusing

[matkoniecz]

fixes ideditor/schema-builder#216

Description, Motivation & Context

intended to replace weird and unusual construct with more widely used one, to achieve the same effect

Related issues

ideditor/schema-builder#216

Links and data

Relevant OSM Wiki links:

none

Relevant tag usage stats:

none

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

1. After you submit your PR, the system will create a preview and comment on your PR:

   🍱 Your pull request preview is ready.
   If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

2. Once the preview is ready, use it to test your changes.

3. Now copy the snippet below into a new comment and fill out the blanks.

4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[k-yle]

I think we'll need to update iD first – If you create a node tagge with @template=poi, this preset will now match, which is unexpected

[matkoniecz]

I think that an internal preset appearing if someone puts in unreasonable tagging is entirely fine.

[matkoniecz]

I think we'll need to update iD first – If you create a node tagge with @template=poi, this preset will now match, which is unexpected

actually, it will not

to check: is it still true after e5f076c

[matkoniecz]

still does not

[k-yle]

actually, it will not

for completeness: it is matching, which is why you can see contact:facebook in moreFields. A normal node doesn't have contact:facebook.

whether this matters is a different question 🤷

[matkoniecz]

I was happy that label will not change. I will check how it changes influence on fields but if adding truly weird tag will cause some moreFields to match I see no problem

[matkoniecz]

Actually, "point has no tags" error disappearing and facebook presets appearing in moreTags is not being changed from the current iD anyway.

[tyrasd]

yeah, the idea to have this (admittedly quite confusing) construct was to make the preset never actually match any osm feature, even in the case that a user was adding the @template dummy tag on purpose. But for some reason it is not working as expected right now. I'll investigate this.

Also, it would probably less confusing to model it like locationSet: { exclude: ["Planet"] }